-
-
Notifications
You must be signed in to change notification settings - Fork 422
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add example usage to documentation, minor bugfixes to environments #906
Add example usage to documentation, minor bugfixes to environments #906
Conversation
…render mode in example script)
…anymore, cleaned up wording
Doing pytest -v the leduc holdem test currently fails but when I remove my changes (adding a simple render() call to the step function) the fail still occurs. Will look into the cause of it and try to fix it though. All other tests seem to pass. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall a very good PR. I wonder why no one else has caught the render in step catch before (myself included), and the documentation improvements are definitely much needed. There's just one minor comment --- but I presume that's to match the gymnasium way of doing things.
@@ -43,7 +43,7 @@ butterfly = ["pygame==2.1.3.dev8", "pymunk==6.2.0"] | |||
mpe = ["pygame==2.1.3.dev8"] | |||
sisl = ["pygame==2.1.3.dev8", "box2d-py==2.3.5", "scipy>=1.4.1"] | |||
other = ["pillow>=8.0.1"] | |||
tests = [ | |||
testing = [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is there a need for this change?
Yep it was just for consistency, drove me crazy having to remember if it’s tests or testing but other repos use testing |
Description
Type of change
Documentation update
pre-commit
checks withpre-commit run --all-files
(seeCONTRIBUTING.md
instructions to set it up)pytest -v
and no errors are present.pytest -v
has generated that are related to my code to the best of my knowledge.