Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo: BaseParallelWraper renamed to BaseParallelWrapper #876

Merged
merged 1 commit into from
Mar 20, 2023

Conversation

mikcnt
Copy link
Contributor

@mikcnt mikcnt commented Jan 4, 2023

Description

As title, fix typo of BaseParallelWrapper (previously BaseParallelWraper). Linked to its SuperSuit counterpart Farama-Foundation/SuperSuit#204.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • I have run the pre-commit checks with pre-commit run --all-files (see CONTRIBUTING.md instructions to set it up)
  • I have run pytest -v and no errors are present.
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I solved any possible warnings that pytest -v has generated that are related to my code to the best of my knowledge.
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@WillDudley
Copy link
Contributor

Thanks for this! Please may you fix the following:

Traceback (most recent call last):
  File "cleanrl.py", line 13, in <module>
    from supersuit import color_reduction_v0, frame_stack_v1, resize_v1
  File "/opt/hostedtoolcache/Python/3.7.15/x64/lib/python3.7/site-packages/supersuit/__init__.py", line 1, in <module>
    from .generic_wrappers import *  # NOQA
  File "/opt/hostedtoolcache/Python/3.7.15/x64/lib/python3.7/site-packages/supersuit/generic_wrappers/__init__.py", line 1, in <module>
    from .frame_skip import frame_skip_v0  # NOQA
  File "/opt/hostedtoolcache/Python/3.7.15/x64/lib/python3.7/site-packages/supersuit/generic_wrappers/frame_skip.py", line 5, in <module>
    from pettingzoo.utils.wrappers import BaseWrapper, BaseParallelWraper
ImportError: cannot import name 'BaseParallelWraper' from 'pettingzoo.utils.wrappers' (/home/runner/work/PettingZoo/PettingZoo/pettingzoo/utils/wrappers/__init__.py)

@mikcnt
Copy link
Contributor Author

mikcnt commented Jan 4, 2023

Sure thing! I was actually thinking about it, do you want me to open a PR in SuperSuit and refactor BaseParallelWrapper there as well?

@jjshoots
Copy link
Member

jjshoots commented Jan 4, 2023

@mikcnt that would be ideal, yes. :)

@mikcnt
Copy link
Contributor Author

mikcnt commented Jan 5, 2023

@WillDudley @jjshoots I've opened a PR on SuperSuit as well (Farama-Foundation/SuperSuit#204). Let me know if that's enough!

Copy link
Member

@jjshoots jjshoots left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Honestly, the fix is so straightforward and I just want to get this overwith. Already merged the one on SS so hopefully this one passes, otherwise I'll hot fix it.

@jjshoots jjshoots merged commit 7ee96af into Farama-Foundation:master Mar 20, 2023
@mikcnt
Copy link
Contributor Author

mikcnt commented Mar 20, 2023

Sorry, didn't see the message before. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants