Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace setup.py with pyproject.toml #875

Merged
merged 19 commits into from
Jan 4, 2023
Merged

Replace setup.py with pyproject.toml #875

merged 19 commits into from
Jan 4, 2023

Conversation

jjshoots
Copy link
Member

@jjshoots jjshoots commented Jan 3, 2023

No description provided.

@jjshoots jjshoots changed the title toml switch toml switch und fix der 3.11 Jan 3, 2023
@jjshoots
Copy link
Member Author

jjshoots commented Jan 4, 2023 •
edited
Loading

@WillDudley I've fixed the 3.11 issues in this PR, do you mind giving it a review?

@pseudo-rnd-thoughts Do you mind giving the setup.py to toml file change a look?

pseudo-rnd-thoughts
pseudo-rnd-thoughts approved these changes Jan 4, 2023
View reviewed changes
Copy link
Member

@pseudo-rnd-thoughts pseudo-rnd-thoughts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not super familiar with pyproject.toml file but this looks generally good, except my files

@pseudo-rnd-thoughts pseudo-rnd-thoughts changed the title toml switch und fix der 3.11 Replace setup.py with pyproject.toml Jan 4, 2023
@jjshoots
Copy link
Member Author

jjshoots commented Jan 4, 2023

@WillDudley should be ready to merge

@WillDudley WillDudley merged commit 6bde09b into Farama-Foundation:master Jan 4, 2023
@jjshoots jjshoots deleted the toml_switch branch January 4, 2023 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WillDudley WillDudley WillDudley left review comments

@pseudo-rnd-thoughts pseudo-rnd-thoughts pseudo-rnd-thoughts approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jjshoots @WillDudley @pseudo-rnd-thoughts