Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change paradigm of parallel api loops #847

Merged
merged 1 commit into from
Oct 31, 2022
Merged

change paradigm of parallel api loops #847

merged 1 commit into from
Oct 31, 2022

Conversation

WillDudley
Copy link
Contributor

I didn't like how we used for step in range(max_cycles) before, now that we have truncation.

@WillDudley
change paradigm of parallel api loops
aa76581 
I didn't like how we used `for step in range(max_cycles)` before, now that we have `truncation`.
@WillDudley
Copy link
Contributor Author

WillDudley commented Oct 31, 2022 •
edited
Loading

@jjshoots This makes sense right? (You handle this thing slightly differently in your CleanRL PPO tutorial)

@WillDudley WillDudley requested a review from jjshoots October 31, 2022 11:16
jjshoots
jjshoots approved these changes Oct 31, 2022
View reviewed changes
Copy link
Member

@jjshoots jjshoots left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this makes sense to me.

@WillDudley WillDudley merged commit 50579c6 into master Oct 31, 2022
@WillDudley WillDudley deleted the WillDudley-patch-2 branch November 2, 2022 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jjshoots jjshoots jjshoots approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@WillDudley @jjshoots