Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pre-commit #835

Merged
merged 34 commits into from
Mar 10, 2023
Merged

Fix pre-commit #835

merged 34 commits into from
Mar 10, 2023

Conversation

jjshoots
Copy link
Member

@jjshoots jjshoots commented Oct 22, 2022

Description

This was the sequence space implementation for KAZ, but somehow the PR got merged somewhere, so now this just fixed precommit.

@RedTachyon
Copy link
Member

Do I understand correctly that this graph would have no edges? Maybe it would be more suitable to use the Sequence space from the newer versions of gymnasium?

@jjshoots
Copy link
Member Author

The original idea was for it to be one node (the agent itself) and n edges for the n entities that it can observe. But the Graph space doesn't allow edges that connect to nothing, so it's all just nodes.

I thought about sequence space, but semantically it seems kind of weird - a sequence represents a sequence of objects, like words in a sentence, whereas a graph doesn't have order to it.

But you're right, maybe a sequence space is better.

@jjshoots jjshoots changed the title Long awaited graph spaces for KAZ Sequence spaces for KAZ Feb 13, 2023
@vercel
Copy link

vercel bot commented Feb 22, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
petting-zoo ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Feb 23, 2023 at 1:39PM (UTC)

@jjshoots jjshoots changed the title Sequence spaces for KAZ Fix pre-commit Mar 10, 2023
@jjshoots jjshoots merged commit 66ebabf into Farama-Foundation:master Mar 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants