Added single quotes around pip install arguments with square brackets #1153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
>pip install pettingzoo[atari] Results in zsh complaining as zsh by default uses [square brackets for globbing](https://stackoverflow.com/questions/30539798/zsh-no-matches-found-requestssecurity). Putting pettingzoo[atari] and pettingzoo[all] inside single quotes makes these commands work with zsh.
|
Good catch, I believe some of our other documentation uses double quotes, any chance you could check to see that all usages of pip install are consistent? Not sure if double or single matters either |
|
I'll fix the other ones, thanks for the PR |
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Results in zsh complaining as zsh by default uses square brackets for globbing.
Putting pettingzoo[atari] and pettingzoo[all] inside single quotes makes these commands work with zsh.
Description
Updated pip install commands in README.md to work with zsh.
Type of change
Checklist:
pre-commitchecks withpre-commit run --all-files(seeCONTRIBUTING.mdinstructions to set it up)pytest -vand no errors are present.