Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sb3 tutorials typo #1133

Merged
merged 3 commits into from
Nov 15, 2023
Merged

Fix sb3 tutorials typo #1133

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8d88172
Update sb3_kaz_vector.py
Fernadoo Nov 14, 2023
8fa57a7
Update sb3_kaz_vector.py
Fernadoo Nov 14, 2023
07d75ec
Update other SB3 tutorials to reflect bugfix in KAZ tutorial
elliottower Nov 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions tutorials/SB3/kaz/sb3_kaz_vector.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,8 +98,8 @@ def eval(env_fn, num_games: int = 100, render_mode: str | None = None, **env_kwa
for agent in env.agent_iter():
obs, reward, termination, truncation, info = env.last()

for agent in env.agents:
rewards[agent] += env.rewards[agent]
for a in env.agents:
rewards[a] += env.rewards[a]

if termination or truncation:
break
Expand Down
4 changes: 2 additions & 2 deletions tutorials/SB3/pistonball/sb3_pistonball_vector.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,8 +99,8 @@ def eval(env_fn, num_games: int = 100, render_mode: str | None = None, **env_kwa
obs, reward, termination, truncation, info = env.last()

if termination or truncation:
for agent in env.agents:
rewards[agent] += env.rewards[agent]
for a in env.agents:
rewards[a] += env.rewards[a]
break
else:
act = model.predict(obs, deterministic=True)[0]
Expand Down
4 changes: 2 additions & 2 deletions tutorials/SB3/waterworld/sb3_waterworld_vector.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,8 +78,8 @@ def eval(env_fn, num_games: int = 100, render_mode: str | None = None, **env_kwa
for agent in env.agent_iter():
obs, reward, termination, truncation, info = env.last()

for agent in env.agents:
rewards[agent] += env.rewards[agent]
for a in env.agents:
rewards[a] += env.rewards[a]
if termination or truncation:
break
else:
Expand Down