Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIx typo in docs #1123

Closed
wants to merge 2 commits into from
Closed

Conversation

matteobettini
Copy link
Contributor

Description

There was a typo in the agent names of simple_reference

@elliottower
Copy link
Contributor

Looks like pre commit is failing but otherwise fine, can you reference the code where this is shown to be correct? Just for reference and to be sure, not too familiar with the MPE envs myself

@matteobettini
Copy link
Contributor Author

Here is the reference

@elliottower
Copy link
Contributor

Can you run pre commit? Good otherwise. I could make a new pr and do this from your branch if you can’t figure out pre commit though, but would be more complicated

@elliottower
Copy link
Contributor

I ran the pre-commit locally and was unable to reproduce the error in CI, re-running CI it fails still, it seems that it's interpreting strings as python code in gen_env_mds.py as python:

docs/_scripts/graph_gen.py:57:41: E231 missing whitespace after ';'
    innards += f"a{len(words)-1} -> a{0};\n"
                                        ^
docs/_scripts/graph_gen.py:70:55: E231 missing whitespace after ','
    out_path = f"docs/assets/img/aec/{name.replace('/','_')}_aec.svg"
                                                      ^
pettingzoo/atari/base_atari_env.py:110:93: E231 missing whitespace after ':'
                f"rom {game} is not installed. Please install roms using AutoROM tool (https://github.com/Farama-Foundation/AutoROM) "
                                                                                            ^
pettingzoo/mpe/_mpe_utils/simple_env.py:327:48: E231 missing whitespace after ':'
                        "[" + ",".join([f"{comm:.2f}" for comm in entity.state.c]) + "]"

Your PR shouldn't affect any of this, I'll try to dig and see if I can fix the issue myself

@elliottower
Copy link
Contributor

Okay I think I found the issue, it was that actions checkout was using python version 3.12, will fix that to specify a python version and check for any other python version specifics anywhere else that could lead to issues.

@elliottower
Copy link
Contributor

Okay I've made a new PR which fixes these but includes your commits so you still get credit, closing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants