Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Ray tutorials to RLlib 2.7.0 #1112

Merged
merged 5 commits into from
Oct 13, 2023
Merged

Update Ray tutorials to RLlib 2.7.0 #1112

merged 5 commits into from
Oct 13, 2023

Conversation

elliottower
Copy link
Contributor

@elliottower elliottower commented Oct 4, 2023

Description

Ray 2.7.0 is out now so it should work with the PettingZoo changes incorporated (there was previously a TODO about adding this once the next release from 2.6.2 was out).

Edit: looks like the tutorial code takes 35+ minutes to run. Going to just leave it disabled in CI, after confirming that it does work locally and in CI.

Fixes # (issue), Depends on # (pull request)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Screenshots

Please attach before and after screenshots of the change if applicable.
To upload images to a PR -- simply drag and drop or copy paste.

Checklist:

  • I have run the pre-commit checks with pre-commit run --all-files (see CONTRIBUTING.md instructions to set it up)
  • I have run pytest -v and no errors are present.
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I solved any possible warnings that pytest -v has generated that are related to my code to the best of my knowledge.
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@elliottower elliottower changed the title Re-add ray tutorial tests Update Ray tutorials to RLlib 2.7.0 Oct 4, 2023
@elliottower
Copy link
Contributor Author

Looks like it took over six hours in CI, though on my laptop I had it working fine in the post in not too long, but maybe that’s because 12 threads instead of zero. May try to change the hyper params to be way less by default.

@elliottower elliottower merged commit 43d9427 into master Oct 13, 2023
47 checks passed
@elliottower elliottower deleted the elliottower-patch-1 branch October 13, 2023 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant