-
-
Notifications
You must be signed in to change notification settings - Fork 422
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix syntax/imports for python blocks in /docs #1075
Fix syntax/imports for python blocks in /docs #1075
Conversation
from shimmy import DmControlMultiAgentCompatibilityV0 | ||
#TODO ModuleNotFoundError: No module named 'dm_control' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This one requires pip install shimmy[dm-control] or all, I think it’s possible to make a pytest fixture or some sort of thing to basically say when doing import shimmy, we have to install it (or mock it but ideally it would actually test it)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I’d have to test locally but my guess is if the pytest docs can run the pettingzoo scripts then we can have it install shimmy as well.
@Bamboofungus tagging you just in case you missed my comments |
Closing in favor of other PR #1083 |
Description
notest
to python markdown blocks that I either don't know how to resolve the errors, are supposed to fail (Like the one forDeprecatedModule
), or have too many side effectsTo test:
(I'm skipping the /_scripts folder since trying to test those creates a lot of files atm)
Type of change
Screenshots
Checklist:
pre-commit
checks withpre-commit run --all-files
(seeCONTRIBUTING.md
instructions to set it up)pytest -v
and no errors are present.pytest -v
has generated that are related to my code to the best of my knowledge.