logging and test created for close_before_reset, gamma and SISL pass …

…new test

pettingzoo/gamma/knights_archers_zombies/knights_archers_zombies.py

@@ -504,7 +504,9 @@ def render(self, mode="human"):
             pygame.display.flip()
 
     def close(self):
-        if not self.closed:
+        if not self.has_reset:
+            EnvLogger.warn_close_before_reset()
+        elif not self.closed:
             self.closed = True
             if not self.render_on:
                 EnvLogger.warn_close_unrendered_env()

pettingzoo/gamma/pistonball/pistonball.py

@@ -123,7 +123,9 @@ def enable_render(self):
         self.reset()
 
     def close(self):
-        if not self.closed:
+        if not self.has_reset:
+            EnvLogger.warn_close_before_reset()
+        elif not self.closed:
             self.closed = True
             if not self.renderOn:
                 EnvLogger.warn_close_unrendered_env()

pettingzoo/gamma/prison/prison.py

@@ -232,7 +232,9 @@ def convert_coord_to_prisoner_id(self, c):
         return self.prisoner_mapping[c]
 
     def close(self):
-        if not self.closed:
+        if not self.has_reset:
+            EnvLogger.warn_close_before_reset()
+        elif not self.closed:
             self.closed = True
             if self.rendering:
                 pygame.event.pump()

pettingzoo/sisl/multiwalker/multiwalker.py

@@ -45,7 +45,10 @@ def reset(self, observe=True):
             return self.observe(self.agent_selection)
 
     def close(self):
-        self.env.close()
+        if not self.has_reset:
+            EnvLogger.warn_close_before_reset()
+        else:
+            self.env.close()
 
     def render(self, mode="human"):
         if not self.has_reset:

pettingzoo/sisl/pursuit/pursuit.py

@@ -44,7 +44,9 @@ def reset(self, observe=True):
             return self.observe(self.agent_selection)
 
     def close(self):
-        if not self.closed and self.has_reset:
+        if not self.has_reset:
+            EnvLogger.warn_close_before_reset()
+        elif not self.closed and self.has_reset:
             self.closed = True
             self.env.close()
 

pettingzoo/sisl/waterworld/waterworld.py

@@ -42,7 +42,10 @@ def reset(self, observe=True):
             return self.observe(self.agent_selection)
 
     def close(self):
-        self.env.close()
+        if not self.has_reset:
+            EnvLogger.warn_close_before_reset()
+        else:
+            self.env.close()
 
     def render(self, mode="human"):
         if not self.has_reset:

pettingzoo/tests/api_test.py

@@ -335,6 +335,8 @@ def test_requires_reset(env):
     if "render.modes" in env.metadata and len(env.metadata["render.modes"]) > 0:
         if not check_asserts(lambda: env.render(), "reset() needs to be called before render"):
             warnings.warn("env.render should call EnvLogger.error_render_before_reset if it is called before reset")
+    if not check_warns(lambda: env.close(), "reset() needs to be called before close."):
+        warnings.warn("env should warn_close_before_reset() if closing before reset()")
 
 
 def test_bad_actions(env):

pettingzoo/utils/env_logger.py

@@ -42,6 +42,10 @@ def warn_action_is_NaN(backup_policy):
     def warn_close_unrendered_env():
         EnvLogger._generic_warning("[WARNING]: Called close on an unrendered environment.")
 
+    @staticmethod
+    def warn_close_before_reset():
+        EnvLogger._generic_warning("[WARNING]: reset() needs to be called before close.")
+
     @staticmethod
     def warn_on_illegal_move():
         EnvLogger._generic_warning("[WARNING]: Illegal move made, game terminating with current player losing. \nenv.infos[player]['legal_moves'] contains a list of all legal moves that can be chosen.")
@@ -54,9 +58,6 @@ def error_observe_before_reset():
     def error_step_before_reset():
         assert False, "reset() needs to be called before step"
 
-    @staticmethod
-    def error_close_before_reset():
-        assert False, "reset() needs to be called before close"
 
     @staticmethod
     def error_render_before_reset():