Revamp publishing workflow #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agriyakhetarpal
commented
Dec 4, 2024
Comment on lines
+31
to
+32
| environment: | ||
| name: pypi |
There was a problem hiding this comment.
This environment would need to be set up in the GitHub and PyPI settings before we are able to publish wheels.
There was a problem hiding this comment.
Also, it would be nice to have more than one reviewer that approves the deployment – the idea is that it should be very hard for someone unauthorised to push to PyPI.
Co-authored-by: Saransh Chopra <[email protected]>
|
https://github.com/FaradayInstitution/BPX/actions/runs/12184220871/attempts/1#summary-33987577687 displays the sdist + wheel inspection added in action. I'll remove the commit that triggered the workflow from the history. |
agriyakhetarpal
force-pushed
the
fix/pypi-workflow
branch
from
073df1e to
179c278
Compare
Saransh-cpp
approved these changes
Dec 5, 2024
rtimms
approved these changes
Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #75