gh-763: Fixed drawing of History menu border after refresh (Ctrl+R
) and clear (Del
).
#892
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Now History menu border and shadow does not disappear when the history is refreshed (
Ctrl+R
) or cleared (Del
) with the menu filter turned on.References
Checklist
If not checked, I accept that this work might be rejected in favor of a different great big ineffable plan.
Details
Even after half a year of debugging (although it was very busy half a year, and I could not spend much time on it), I still cannot understand how History menu works (for that matter, I do not understand how Far windowing system works). Thus, the fix is done somewhat blindly. In my limited testing, everything seems to work and there was no perceptible performance regression. However, I will not be surprised if I broke some other subtle scenario.