Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-763: Fixed drawing of History menu border after refresh (Ctrl+R) and clear (Del). #892

Merged
merged 1 commit into from
Dec 20, 2024

Conversation

MKadaner
Copy link
Contributor

Summary

Now History menu border and shadow does not disappear when the history is refreshed (Ctrl+R) or cleared (Del) with the menu filter turned on.

References

Checklist

  • I have followed the contributing guidelines.
  • I have discussed this with project maintainers:

    If not checked, I accept that this work might be rejected in favor of a different great big ineffable plan.

Details

Even after half a year of debugging (although it was very busy half a year, and I could not spend much time on it), I still cannot understand how History menu works (for that matter, I do not understand how Far windowing system works). Thus, the fix is done somewhat blindly. In my limited testing, everything seems to work and there was no perceptible performance regression. However, I will not be surprised if I broke some other subtle scenario.

@alabuzhev alabuzhev merged commit 029e057 into FarGroup:master Dec 20, 2024
51 checks passed
@alabuzhev
Copy link
Contributor

Thank you

@MKadaner MKadaner deleted the mzk/gh-763/history-menu-refresh branch December 20, 2024 19:57
@MKadaner
Copy link
Contributor Author

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants