-
Notifications
You must be signed in to change notification settings - Fork 221
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ModuleNotFoundError for handful of nodes #3
Comments
Also, not really worth opening a new issue for since the repo is still pretty young it looks like, but comfyui_controlnet_aux/README.md Line 25 in 0348d82
comfyui_controlnet_aux/install.bat Line 6 in 0348d82
seems like there's still some cruft from importing over stuff from WAS? (Maybe elsewhere too) |
Actually it's not all nodes this fails for, it's just ~7 out of the bunch. When I try to use any of the other modules, though, I get an error like the following. I can open a new issue if it helps, but might be same root cause
|
I actually copied the installation guide and script from him and the logger from comfyui_mtb. |
I think that is not true because I use huggingface_hub to handle the downloading. May be |
Can you test the new commit? |
There are missing “__init__.py” in your package directory, so importlib won't import contronet_aux even src added to sys.path.
|
Oh thanks for your tip! |
Might've got a little worse:
On commit 2a0ee39 Tried first with the old repo enabled, and again without. Same runtime errors as well |
@Lightsockie Can you test the newest commit for once more time? |
Looks like it's still ain't happy. Just did a fresh clone of ComfyUI (using pre-existing venv), with only ComfyUI-Manager and controlnet_aux, to eliminate as much variables as possible. Full error:
|
Same error for me. |
I just installed as well off of ComfyUI Manager just a few minutes ago and get very similar init.py issues (attached) - happy to do a new pull and test. |
+1 to the quick fix @tungnguyensipher ! Thank you. All start-up issues are gone, no node not-loaded warnings, no red nodes. |
This fixed the loading issue for me. Note, make sure you restart ComfyUI and any prior windows/tabs you had open. Unsure if its related, but Is anyone else having issues with the "UniFormer Segmentor" and "OpenPose Pose Recognition" nodes? I'm using the test JSON file at the bottom of the README.md (test_cn_aux_full.json). |
Close this isssue as it is fixed at 582f0ad. Thanks @tungnguyensipher for the fix. I'm still an amateur so this kind of issue is hard for me to fix. |
I found another project with a similar purpose (due to running into this error) Also, your fix won't really fix things (just by looking at the code) you just shifted the error from import-time to when somebody actually tries executing those nodes. The modules you're trying to import there are simply not part of the controlnet-aux.0.0.6 python module that is on PyPi. Nor in 0.0.3 or 0.0.1, so, I'm not sure what's going on there. That said, I'm surprised 2 people said the 1-line fix was enough for them, for me, it made no difference. Keep up the good work, ya'll. |
@Mets3D That is why I use Also the repo you mentioned use the original controlnet-aux which doesn't have stuffs like DWPose or OneFormer. |
What other version of controlnet-aux is out there? That needs to go into requirements.txt, otherwise the errors will keep occurring for people who don't already have those modules installed as a dependency from some other project. |
cmon, manager version is still borked |
not fixed, if you install with manager and it wont error out then you can call it being fixed |
Just re-tested in my "clean" env (just ComfyUI-Manager & this custom node). Confirming this issue is resolved, but there are still some nodes failing that likely need their own issues. Seems kinda odd to use the comfy: bc76b3829f5fbba7c5a439c7833d313a3ca87398 |
Saw the other repo was archived, so just now replaced it with this one. When I try to use any of the nodes, though, I got an error. So I looked back on the startup log and see this. I get a Traceback for each module, but just showing the last one here for brevity (they're all the same
ModuleNotFoundError
issue).I installed via ComfyUI-Manager. After I saw the errors I manually installed the
requirements.txt
file, too, to rule that out as an issue. The error tells me to make sure I installed any dependencies correctly, but I don't see anything more "dependencies" to install beyond this.Torch versions:
When I look in the
ckpts
folder I seeckpts/models--lllyasviel--Annotators
which seems wrong? Especially since I see elsewhere in code references to the pathllyasviel/Annotators
. Could be there's a windows problem on some of the stuff, so maybe there's a pathing issue whereckpts/models\lllyasviel\Annotators
is translating wrong and messing up the imports?The text was updated successfully, but these errors were encountered: