Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
switch to use the falkrdb-py client #8
base: master
Are you sure you want to change the base?
switch to use the falkrdb-py client #8
Changes from 250 commits
0a80e43
b1724bd
dda251a
fefdb21
4bf31b8
38f16d8
ef0dfaf
749f56b
32ea2ec
52272fd
2144535
a196ade
ccded22
3cb8f55
fe2534f
359e75a
bef864d
28f62f1
cb71e37
6f09a88
a044e6b
c3731e1
20fccd5
2f557d8
b483df2
d41e543
d9887b6
9813789
6f42678
e950edf
18de5e1
93aa2cd
772a842
e2a95c6
8ab9095
51e3f8e
cb5d1e5
7b68dad
7487c8e
61288ed
1068ff3
d0a1d13
1d80ead
382f17e
7e2fde3
a8d296b
8b4dc41
d090d3b
aface14
de1e53c
0b8845f
1501f1a
8bd8c48
d8b35f2
e5e9515
7303094
8ab4d80
9cb16fd
1253f7c
16582f9
45ab474
84034f9
4654c4d
0af7e0c
198eab6
f8f8cb0
90f7249
7a69ad2
6909c3c
0657f25
85287fc
fb7d5e8
c84300d
4fd5b5f
a6c57d9
95e950e
61bee93
d71bac5
e162298
249e1af
81645a5
cb1aecd
a0e9f2b
ffd6950
4afa84c
6b76210
2f8ca9d
bd230a8
b58d14a
ef7047e
444c32f
ea3e704
7f369d2
49fd62e
8584e68
2a60bb8
7f16dcf
10db128
3cc39d4
8d8151e
45f3e5b
ac00d81
9657739
5eb0c93
be79a31
c233797
f878b56
5111190
64c8c65
626f13f
cda9204
3582acc
088a421
ffe3944
24cbc7a
5aaedcb
868aff7
98ecf95
73a4b53
5660f66
20404ea
02ecfe8
e05389b
4c70d3b
d2193a0
12de1be
38aed4b
84bb256
9c93f17
44f3743
bd395cf
0044435
81544ff
5b22c05
69d22b2
59b0ea1
e8016a9
c1bf25b
fb380bf
260f992
cdf059f
add3357
ea6a6ce
def0a27
5447189
2586737
65fa76b
401f310
99a8c66
474d6aa
283feb1
822a121
aed54ab
4eff701
eb5c2f9
79b9722
391ce95
1dbcad8
7a5bdc8
02c27ae
890e7e3
caa5540
1aa3ac0
a091fec
131f58b
ec2df37
06de9d7
2abe3cd
40c4bd4
ab53587
8aec5e6
28351d6
1dabc46
f5ceb0d
42f5333
12cfe61
091cc1d
dfde517
6fb5547
0426b40
481b744
125763b
8d2e5c6
1708029
b286bd8
6001077
ef2b3cd
ec1bb5a
ea74dc6
861e9a8
6f847df
3a7d5e4
bc3cbfa
8670f3d
a093598
b3f5c19
2b622e6
6eadb97
42ba91d
0903ade
d8f2cf1
6a78c98
d31c802
9724ed5
d437849
1b882f4
da408a5
8ea14b1
c08b96b
587d044
eda18b2
68c49b0
c374d4e
b46f906
0ef537b
1f08c9b
45bcbb1
133791e
ba5b7a6
b964531
6b6afec
a8eb88d
28477f1
d885f5b
b19d2f0
254dfdb
206cb88
8c1f7a7
1d4c38c
2b476fa
83d14b9
2aa0ff1
44763e6
4b00287
01d65e0
c5db0c9
131fc18
eddc1a2
d5947ff
770e73c
2829748
b84bcbf
71bdc36
4f57eb1
4d71ca2
b0f6049
db7984a
e4f146d
9581049
6ea9efb
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The connection to FalkorDB is correctly established within a try-except block, which is a good practice for handling connection errors. However, consider using more specific exceptions for better error handling and clarity.
Note: Replace
FalkorDBConnectionError
andFalkorDBAuthenticationError
with the specific exceptions thrown byFalkorDB
for connection and authentication failures.Committable suggestion
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The method
select_graph
is used without explicit error handling for cases where the specified database does not exist or is inaccessible. Adding error handling here would improve robustness.Note: Replace
FalkorDBGraphNotFoundError
with the specific exception thrown byFalkorDB
if the graph is not found.Committable suggestion
The
add_graph_documents
method does not handle exceptions that may occur during the query execution. Implementing error handling here would ensure atomicity or rollback in case of failures, improving the robustness of graph updates.Implement error handling in the
add_graph_documents
method to handle exceptions during query execution.