Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doesn't work in rxvt; just reprints list of commits #11

Open
yggdr opened this issue Jan 30, 2017 · 10 comments
Open

Doesn't work in rxvt; just reprints list of commits #11

yggdr opened this issue Jan 30, 2017 · 10 comments

Comments

@yggdr
Copy link

yggdr commented Jan 30, 2017

In rxvt-unicode 9.22 on FreeBSD 11.0 (using zsh and /bin/sh) git recall prints the commits, but hitting j/k/Up/Down just prints out the same commits once more. No commit is marked like in the gif at any time. Tab has a similar effect of partial reprint of the lines.

@Teszko
Copy link
Contributor

Teszko commented Jan 30, 2017

Works on Debian linux, rxvt-unicode 9.20
This seems to be the same bug as #6

@agarzola
Copy link

Same happens on OS X 10.11.6.

@mkermani144
Copy link

mkermani144 commented Jan 31, 2017

Same on Ubuntu 16.04; However, if I maximize the terminal window, the problem will no longer exist.

@mangelsnc
Copy link

Same as @mkermani144 an @agarzola and in addition, if I press tab key to expand the commit, just reprints again the next line.

@desko27
Copy link

desko27 commented Feb 3, 2017

Hi, nice project! I have tested it in Git console for Windows (MinGW). I know the Readme says a Linux/OSX OS is required, but it seemed to me that it works just fine under MinGW except for this bug. I experience the same thing, every time I press Up/Down keys, the list of commits is reprinted leaving a duplicated first line behind.

@wagnerand
Copy link

wagnerand commented Feb 6, 2017

At least on Mac 10.12.3 (and in my case) this is due to Apple's sed flavor behaving differently than GNU sed. If you download the GNU flavor and change the call to the executable, it works.

@yggdr
Copy link
Author

yggdr commented Feb 6, 2017

This indeed fixes the main functionality (going through the list, opening them with tab), but not the reprinting and highlighting one.

expobrain pushed a commit to expobrain/git-recall that referenced this issue Mar 29, 2017
@Fakerr
Copy link
Owner

Fakerr commented Jun 11, 2017

Problem resolved on OS X with bash 4.3 or more.

@Fakerr Fakerr closed this as completed Jun 11, 2017
@yggdr
Copy link
Author

yggdr commented Jun 11, 2017

Erm, no. Why would bash fix this?

In rxvt-unicode 9.22 on FreeBSD 11.0 (using zsh and /bin/sh)
Current code from master (9c53028) is still nonfunctioning on FreeBSD 11.0 with urxvt and zsh.

@Fakerr Fakerr reopened this Jun 11, 2017
@Fakerr
Copy link
Owner

Fakerr commented Jun 11, 2017

Well, upgrading to bash 4.4 in mac OS + some fixes I added resolved the issue, but I didn't try on FreeBSD to be honest. Did you try it with bash and it didn't work ? @yggdr

@Fakerr Fakerr closed this as completed Jun 11, 2017
@Fakerr Fakerr reopened this Jun 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

8 participants