Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Disable findUnusedCode option #637

Merged
merged 1 commit into from
Apr 27, 2023
Merged

Fix: Disable findUnusedCode option #637

merged 1 commit into from
Apr 27, 2023

Conversation

localheinz
Copy link
Member

@localheinz localheinz commented Apr 27, 2023 •
edited
Loading

What is the reason for this PR?

  • disables the findUnusedCode option

💁‍♂️ Running

vendor/bin/psalm

on current main yields

Warning: "findUnusedCode" will be defaulted to "true" in Psalm 6. You should explicitly enable or disable this setting.

Author's checklist

Summary of changes

Review checklist

  • All checks have passed
  • Changes are approved by maintainer

@localheinz localheinz changed the title Fix: Disable findUnusedCode option Fix: Disable findUnusedCode option Apr 27, 2023
@localheinz localheinz added the bug Something isn't working label Apr 27, 2023
@pimjansen pimjansen merged commit da0dad1 into FakerPHP:main Apr 27, 2023
@localheinz localheinz deleted the fix/find-unused-code branch April 27, 2023 20:20
@localheinz
Copy link
Member Author

Thank you, @pimjansen!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pimjansen pimjansen pimjansen approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@localheinz @pimjansen