Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed ${var} usage - deprecated in PHP 8.2 #591

Merged
merged 1 commit into from
Jan 3, 2023
Merged

Removed ${var} usage - deprecated in PHP 8.2 #591

merged 1 commit into from
Jan 3, 2023

Conversation

janlanger
Copy link

@janlanger janlanger commented Jan 3, 2023 •
edited
Loading

What is the reason for this PR?

Using ${var} in strings is deprecated in PHP 8.2. This is the only usages I found in the library

  • A new feature
  • Fixed an issue (resolve #ID)

Author's checklist

Review checklist

  • All checks have passed
  • Changes are approved by maintainer

@pimjansen pimjansen merged commit 14d4f13 into FakerPHP:main Jan 3, 2023
@janlanger janlanger deleted the patch-1 branch January 3, 2023 20:06
@localheinz localheinz added the bug Something isn't working label Jan 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pimjansen pimjansen pimjansen approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@janlanger @pimjansen @localheinz