Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed the name Adolf and similarities #584

Merged
merged 1 commit into from
Jan 5, 2023
Merged

Conversation

Joas707
Copy link

@Joas707 Joas707 commented Dec 27, 2022

What is the reason for this PR?

In a few data sets, there was a name Adolf, Adolph or something similar. It is not appropriate to give the name Adolph to a person, as it is associated with Adolf Hitler, who was the leader of Nazi Germany during World War II and responsible for the deaths of millions of people, including six million Jews. The use of this name would be offensive and inappropriate, as it is associated with one of the most heinous regimes in history.

This fix is especially useful for people who use this database for seeding test data what will be seen by management and possible customers. This wil avoid misunderstandings.

  • A new feature
  • Fixed an issue (resolve #ID)

Author's checklist

Summary of changes

See upper paragraph

Review checklist

  • All checks have passed
  • Changes are approved by maintainer

@pimjansen
Copy link

We do not just update datasets since someone does not agree with the content overall. Adolf is a common German name so i do not really see any problem here?

@localheinz as a native can you shed some light maybe?

@bram-pkg
Copy link
Member

bram-pkg commented Dec 27, 2022 via email

@pimjansen
Copy link

@Joas707 can you ensure only the name Adolf is removed?

@Joas707
Copy link
Author

Joas707 commented Jan 4, 2023

Yes of course! But in that case I suggest to also remove Adolph as well, because that name is so similar, especially in spoken language.

@localheinz localheinz added the bug Something isn't working label Jan 4, 2023
@localheinz
Copy link
Member

@pimjansen

We do not just update datasets since someone does not agree with the content overall. Adolf is a common German name so i do not really see any problem here?

@localheinz as a native can you shed some light maybe?

I have found an article from 2018 that claims that (at the time of writing) 46.171 people still have that name in Germany. I believe, however, that the name is not very popular in Germany.

Regardless, I recall @fzaninotto arguing against removing (or modifying) data sets. I guess it depends on how people use the generated data. I do not care much about the data itself, just that the data makes some sense in the context I use it in.

Given that variations of the name in other languages may be popular in the countries where these languages are spoken, I am not sure what the best approach would be here.

Copy link
Member

@bram-pkg bram-pkg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@pimjansen pimjansen merged commit b47968e into FakerPHP:main Jan 5, 2023
@gregorygonzalez87
Copy link

While I'd question why that name was added in the first place, I don't see any reason to remove it. Plenty of people in Germany still name their children Adolf. By this logic, we should arrest anyone with the name Adolf....dumb.

@bram-pkg
Copy link
Member

bram-pkg commented May 22, 2023

The name was added as part of a larger dataset, surely.

You should look up how many new kids are being born that call are called Adolf.

@ioSeoGio
Copy link

Do you know who also drank water? Hitler

@FakerPHP FakerPHP locked as too heated and limited conversation to collaborators May 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants