Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Do not bother running tests on Windows #547

Merged
merged 1 commit into from
Dec 6, 2022

Conversation

localheinz
Copy link
Member

@localheinz localheinz commented Dec 6, 2022

What is the reason for this PR?

  • stops running tests on Windows

Author's checklist

Summary of changes

Review checklist

  • All checks have passed
  • Changes are approved by maintainer

@bram-pkg bram-pkg merged commit ca8f1cc into FakerPHP:main Dec 6, 2022
@localheinz localheinz deleted the fix/windows branch December 6, 2022 10:47
@localheinz
Copy link
Member Author

Thank you, @bram-pkg!

@pimjansen
Copy link

One small thing, should we write this in the docs what the supported platforms are? If we drop 7.4 and windows we should make that clear right @bram-pkg

@bram-pkg
Copy link
Member

bram-pkg commented Dec 6, 2022

Yeah, we should add docs section (requirements and platforms)

Tests are not run on windows, that's all

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants