-
Notifications
You must be signed in to change notification settings - Fork 355
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Drop support for PHP 7.1, 7.2, and 7.3 #543
Conversation
3f5d28a
to
4331eea
Compare
This sounds like a good change. Technically don't have to wait for 2.0 for this, since I don't think |
ccc39a9
to
e67b3d2
Compare
For some reason the bcroave check is failing? |
Build failure seems unrelated to me, not sure what the problem is. Since we use https://github.com/Nyholm/roave-bc-check-docker here, can you take a look, please? |
Opened an issue at Nyholm/roave-bc-check-docker#32. |
I don't see much value in this, especially given we're not using any new features. I'd recommend we hold off here for a bit, or maybe go with a less aggressive bump to 7.2.5 as the minimum. |
Where do you see value in supporting outdated PHP versions? |
Where there is little or no effort, it is more effort to drop support than to do nothing. |
I also still use PHP 7 myself... |
I think supporting |
96286c5
to
134e06e
Compare
Thank you, @bram-pkg and @GrahamCampbell! |
What is the reason for this PR?
make baseline
Author's checklist
Summary of changes
Dropping support for outdated PHP versions, see https://www.php.net/supported-versions.php.
Review checklist