Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Drop support for PHP 7.1, 7.2, and 7.3 #543

Merged
merged 1 commit into from
Dec 7, 2022

Conversation

localheinz
Copy link
Member

@localheinz localheinz commented Dec 5, 2022

What is the reason for this PR?

  • drop support for outdated PHP versions
  • runs make baseline

Author's checklist

Summary of changes

Dropping support for outdated PHP versions, see https://www.php.net/supported-versions.php.

Review checklist

  • All checks have passed
  • Changes are approved by maintainer

@localheinz localheinz force-pushed the fix/php branch 3 times, most recently from 3f5d28a to 4331eea Compare December 5, 2022 13:31
@bram-pkg
Copy link
Member

bram-pkg commented Dec 5, 2022

This sounds like a good change. Technically don't have to wait for 2.0 for this, since I don't think composer will update past the version constraints.

@bram-pkg
Copy link
Member

bram-pkg commented Dec 7, 2022

For some reason the bcroave check is failing?

@localheinz
Copy link
Member Author

@bram-pkg

Build failure seems unrelated to me, not sure what the problem is.

@Nyholm

Since we use https://github.com/Nyholm/roave-bc-check-docker here, can you take a look, please?

@localheinz
Copy link
Member Author

@bram-pkg

Opened an issue at Nyholm/roave-bc-check-docker#32.

@GrahamCampbell
Copy link
Member

I don't see much value in this, especially given we're not using any new features. I'd recommend we hold off here for a bit, or maybe go with a less aggressive bump to 7.2.5 as the minimum.

@localheinz
Copy link
Member Author

@GrahamCampbell

Where do you see value in supporting outdated PHP versions?

@GrahamCampbell
Copy link
Member

Where there is little or no effort, it is more effort to drop support than to do nothing.

@GrahamCampbell
Copy link
Member

I also still use PHP 7 myself...

@GrahamCampbell
Copy link
Member

I could be amenable to going with ^7.4 || ^8.0, though.

image

@bram-pkg
Copy link
Member

bram-pkg commented Dec 7, 2022

I think supporting 7.4 is reasonable still, since the previous Laravel version still supports 7.4.

README.md Outdated Show resolved Hide resolved
composer.json Outdated Show resolved Hide resolved
@localheinz localheinz force-pushed the fix/php branch 2 times, most recently from 96286c5 to 134e06e Compare December 7, 2022 13:35
.github/workflows/coding-standards.yml Outdated Show resolved Hide resolved
@localheinz localheinz changed the title Fix: Drop support for outdated PHP versions Fix: Drop support for PHP 7.1, 7.2, and 7.3 Dec 7, 2022
@localheinz localheinz merged commit 9b8d695 into FakerPHP:main Dec 7, 2022
@localheinz
Copy link
Member Author

Thank you, @bram-pkg and @GrahamCampbell!

@localheinz localheinz deleted the fix/php branch December 7, 2022 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants