Improve Turkish phone numbers for E164 and landline support #460
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Missing tests and sources references |
ugurerkan
force-pushed
the
feature/turkish-phone-number-improvement
branch
from
0793ad4
to
ecdd1e9
Compare
|
@pimjansen Thank you for the review, I have added reference for phone numbers in Turkey and updated tr_TR phone number test case to test with e164 phone number. |
ugurerkan
force-pushed
the
feature/turkish-phone-number-improvement
branch
from
ecdd1e9
to
e7fa955
Compare
ugurerkan
changed the title
ugurerkan
changed the title
pimjansen
approved these changes
Mar 7, 2022
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the reason for this PR?
This PR provides e164 phone number support for tr_TR locale.
Also, improves exists phone number format to generate landline phone numbers.
Author's checklist
Summary of changes
The changes are made in tr_TR PhoneNumber provider to support e164 phone number generation and contains addition improvements for phone number generation with landline numbers.
Review checklist