Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: typo in french phone number #452

Merged
merged 1 commit into from
Feb 11, 2022
Merged

fix: typo in french phone number #452

merged 1 commit into from
Feb 11, 2022

Conversation

Nek-
Copy link

@Nek- Nek- commented Feb 11, 2022

What is the reason for this PR?

The goal here is to generate as much as possible valid phone numbers.

The original code was one number too long. French phone numbers contains 10 numbers, starting by 0. But this was not generating always 0 for the first number.

In addition, when it comes to e164, the first 0 number is usually not specified (specifying it seems to be valid, but useless and it's not a usage of french people). The quick fix here is to remove this useless (wrong most part of the time!) number.

  • A new feature
  • Fixed an issue (resolve #ID)

Summary of changes

Fix: Removed a number in french e164 format

Review checklist

  • All checks have passed
  • Changes are approved by maintainer

@bram-pkg
Copy link
Member

LGTM, thanks!

@bram-pkg bram-pkg merged commit ea291fd into FakerPHP:main Feb 11, 2022
@hmazter hmazter mentioned this pull request Jul 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants