Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed some hungarian bugs and functions #451

Merged
merged 5 commits into from
Feb 16, 2022
Merged

Conversation

zsoltjanes
Copy link

@zsoltjanes zsoltjanes commented Feb 8, 2022

What is the reason for this PR?

The hungarian section is fixed, some case was not good.

  • A new feature
  • Fixed an issue

Author's checklist

Summary of changes

Review checklist

  • All checks have passed
  • Changes are approved by maintainer

pimjansen
pimjansen previously approved these changes Feb 10, 2022
Copy link

@pimjansen pimjansen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@bram-pkg can you have a final look?

@pimjansen
Copy link

Lgtm

@bram-pkg can you have a final look?

I was a bit too fast. Missed the BC. Can you review and fix where needed?

@bram-pkg bram-pkg added bug Something isn't working do not merge labels Feb 10, 2022
@zsoltjanes
Copy link
Author

Can you help me what should I check and fix?

@krsriq
Copy link

krsriq commented Feb 14, 2022

@zsoltjanes the BC checker does not like that this removes the $title property and firstNameMaleNe(): https://github.com/FakerPHP/Faker/runs/5137593918?check_suite_focus=true#step:4:114

src/Faker/Provider/hu_HU/Person.php Outdated Show resolved Hide resolved
src/Faker/Provider/hu_HU/Person.php Show resolved Hide resolved
@bram-pkg bram-pkg merged commit a8e53bd into FakerPHP:main Feb 16, 2022
@dorqa95
Copy link

dorqa95 commented Aug 26, 2022

This commit couse me an error with this:
Unknown format "lastNameFemaleMarried". With version 1.19 that bug does not exists. I saw that in the main branch the bug has already fixed. Could you please create a new release with that? #503 #502

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working do not merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants