Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed UUID from Generator to be able to extend it #441

Merged

Conversation

pimjansen
Copy link

@pimjansen pimjansen commented Jan 28, 2022

What is the reason for this PR?

Reverts the addition of the UUID method to the generator

Author's checklist

Summary of changes

Since the method exists directly on the generator the addProvider method is not able to extend these calls anymore. There we revert it for now and ensure that on v2 these methods used. For v2 we can overwrite it with the container builder however at this moment these are still experimental.

Review checklist

  • All checks have passed
  • Changes are approved by maintainer

@pimjansen
Copy link
Author

This also makes #436 obsolete

@pimjansen pimjansen force-pushed the feature/removed-uuid-from-generator branch 2 times, most recently from ff470f1 to bf6fb42 Compare January 28, 2022 10:35
@pimjansen pimjansen mentioned this pull request Jan 31, 2022
4 tasks
@pimjansen pimjansen requested a review from bram-pkg January 31, 2022 17:20
@bram-pkg
Copy link
Member

bram-pkg commented Feb 1, 2022

Can you add an ignore for this to the bc-roave config?

@pimjansen pimjansen force-pushed the feature/removed-uuid-from-generator branch from bf6fb42 to 23f16bc Compare February 2, 2022 08:47
@pimjansen pimjansen added the bug Something isn't working label Feb 2, 2022
@pimjansen
Copy link
Author

@bram-pkg done!

@bram-pkg bram-pkg merged commit 348757a into FakerPHP:main Feb 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't override default formatters
2 participants