Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added the UUID extension to Core and deprecated the global uuid call … #427

Merged
merged 1 commit into from
Jan 23, 2022

Conversation

pimjansen
Copy link

@pimjansen pimjansen commented Jan 21, 2022

…with an uuid3 to specify version

What is the reason for this PR?

Added Uuid provider to Core and deprecated the uuid with an uuid3 to specify version

  • A new feature
  • Fixed an issue (resolve #ID)

Author's checklist

Summary of changes

Review checklist

  • All checks have passed
  • Changes are approved by maintainer

@pimjansen pimjansen force-pushed the feature/uuid-extension branch 2 times, most recently from d05d8f9 to ab2898d Compare January 21, 2022 20:52
@pimjansen pimjansen marked this pull request as ready for review January 21, 2022 20:53
@pimjansen pimjansen force-pushed the feature/uuid-extension branch 2 times, most recently from 967fe52 to 0584d70 Compare January 22, 2022 18:35
@pimjansen pimjansen requested a review from bram-pkg January 22, 2022 18:35
src/Faker/Core/Uuid.php Outdated Show resolved Hide resolved
@pimjansen pimjansen force-pushed the feature/uuid-extension branch from 0584d70 to 0b9d760 Compare January 23, 2022 16:36
@pimjansen pimjansen force-pushed the feature/uuid-extension branch from 0b9d760 to 4a795c8 Compare January 23, 2022 16:39
@pimjansen
Copy link
Author

All changes applied and rebased with main

@bram-pkg bram-pkg merged commit 69dbada into FakerPHP:main Jan 23, 2022
@pimjansen pimjansen deleted the feature/uuid-extension branch January 23, 2022 17:21
krsriq pushed a commit to krsriq/Faker that referenced this pull request Jan 23, 2022
@simPod simPod mentioned this pull request Jan 31, 2022
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants