Fix for support on different Doctrine ORM versions

[icanhazstring]

Add conflict to doctrine/persistence below 1.4 and use correct persistence classes

What is the reason for this PR?

Fix an issue with doctrine/persistnce

• Fixed an issue (resolve Faker/ORM/Doctrine not working with latest doctrine implementations #413 )

Author's checklist

• Follow the Contribution Guide

Summary of changes

• Add a conflict into composer.json for doctrine/persistence below version 1.4
• Add suggest into composer.json for doctrine/orm
• Add doctrine/orm as dev requirement to avoid static analysis baseline entries
• Use new classes of doctrine/orm and doctrine/persistence for Faker\ORM\Doctrine namespace
• Add class_alias for ClassMetadata and ObjectManager

Review checklist

• All checks have passed
• Changes are approved by maintainer

[pimjansen]

This is a BC which we do not allow for v1. Can we ensure that both are supported here?

[icanhazstring]

@pimjansen I can try and do the same doctrine did and add a class_alias
So we could then remove it with v2.

[pimjansen]

@pimjansen I can try and do the same doctrine did and add a class_alias

So we could then remove it with v2.

Correct. For v2 we will remove it from core and can be a community driven extension instead.

[icanhazstring]

Apparently, psalm is failing in CI but not on my machine using the same PHP version.

vendor/bin/psalm
Scanning files...
Analyzing files...

░
------------------------------
No errors found!
------------------------------

Checks took 0.71 seconds and used 234.707MB of memory
Psalm was unable to infer types in the codebase

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed after 1 week if no further activity occurs. Thank you for your contributions.

[fdiedler]

Hope it will be fixed soon, thanks :)

[pimjansen]

@icanhazstring the pipeline is failing, can you review this?

[icanhazstring]

Apparently, psalm is failing in CI but not on my machine using the same PHP version.

vendor/bin/psalm
Scanning files...
Analyzing files...

░
------------------------------
No errors found!
------------------------------

Checks took 0.71 seconds and used 234.707MB of memory
Psalm was unable to infer types in the codebase

@pimjansen see this comment.

[pimjansen]

No idea but ci is leading so needs to be green

[krsriq]

@icanhazstring Running psalm locally is red for me too, works with this psalm.baseline.xml: https://gist.github.com/krsriq/cc1c3ceea2886aa4b93a2b1825a32e7f

[icanhazstring]

@krsriq then there is something weird with the local setup 🤷‍♂️

Guess I'll just add your baseline then.

[icanhazstring]

After all these years.
Now it works.

[bram-pkg]

@icanhazstring is this ready now?

[icanhazstring]

@bram-pkg checked it again against my problem. Fixed for me 👍
LGTM

[pimjansen]

LGTM, also test on 1.3 and 2.x went fine

[crynobone]

This PR caused an issue on projects that don't utilize FakerPHP\ORM\Doctrine

Warning: Class "Doctrine\Persistence\Mapping\ClassMetadata" not found in /Projects/laravel/nova/orion/vendor/fakerphp/faker/src/Faker/ORM/Doctrine/backward-compatibility.php on line 6

Warning: Class "Doctrine\Persistence\ObjectManager" not found in /Projects/laravel/nova/orion/vendor/fakerphp/faker/src/Faker/ORM/Doctrine/backward-compatibility.php on line 10

It seems that FakerPHP expect doctrine/persistent or doctrine/orm to be available for all installation since it always load src/Faker/ORM/Doctrine/backward-compatibility.php, so I don't understand why it was added to require-dev

[icanhazstring]

It was added to require-dev because it is used for development.

But the other case you are correct. Will create a quick fix for that.

[pimjansen]

@crynobone fix has been applied in main