Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updates to en_za/internet #383

Merged
merged 2 commits into from
Oct 17, 2021
Merged

updates to en_za/internet #383

merged 2 commits into from
Oct 17, 2021

Conversation

mikerockett
Copy link

@mikerockett mikerockett commented Oct 16, 2021

What is the reason for this PR?

Add data to the ZA Internet provider namespace (TLDs).

Author's checklist

Summary of changes

This adds gTLDs, the commonly used .africa, and increases the likelihood of a .co.za or .com being used.

Review checklist

  • All checks have passed
  • Changes are approved by maintainer

This adds gTLDs, the commonly used .africa, and increases the likelihood of a .co.za or .com being used.
@pimjansen
Copy link

Can we sort them as mention in the contribution guide?

@mikerockett
Copy link
Author

mikerockett commented Oct 16, 2021

@pimjansen Happy to sort them, however I'm not seeing it mentioned in the contribution guide (am I missing something?), and the original list was not sorted (except that it matched the order of the linked wiki).

Update: List is now sorted alphabetically, and doc block is improved.

@pimjansen pimjansen merged commit d3c0752 into FakerPHP:main Oct 17, 2021
@mikerockett
Copy link
Author

Thanks!

@mikerockett mikerockett deleted the patch-1 branch October 17, 2021 08:09
@GrahamCampbell
Copy link
Member

This should not have been merged with the BC check failing. The BC check config should have been adjusted to explicitly allow this break. I've adjusted the repo config to block this going forward.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants