Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proper format for E.164 numbers #380

Merged
merged 1 commit into from
Oct 12, 2021
Merged

Proper format for E.164 numbers #380

merged 1 commit into from
Oct 12, 2021

Conversation

miken32
Copy link

@miken32 miken32 commented Sep 24, 2021

What is the reason for this PR?

Author's checklist

Summary of changes

Ensure the e164PhoneNumber formatter in en-US locale follows the same rules as other formatters and doesn't generate invalid phone numbers.

Review checklist

  • All checks have passed
  • Changes are approved by maintainer

@stale
Copy link

stale bot commented Oct 9, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed after 1 week if no further activity occurs. Thank you for your contributions.

@stale stale bot added the lifecycle/stale label Oct 9, 2021
@pimjansen
Copy link

Do we have some source for this fix? Im new to US phonenumber so

@stale stale bot removed the lifecycle/stale label Oct 9, 2021
@miken32
Copy link
Author

miken32 commented Oct 9, 2021 via email

@pimjansen pimjansen merged commit 5aa3bfe into FakerPHP:main Oct 12, 2021
@miken32
Copy link
Author

miken32 commented Oct 12, 2021

Thanks very much. Feel free to tag this PR with hacktoberfest-accepted if you guys are participating.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

e164PhoneNumber() generates invalid US Phone Numbers
3 participants