-
Notifications
You must be signed in to change notification settings - Fork 356
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add an Egyptian Arabic (ar_EG) locale #377
Conversation
…to the ar_EG locale
Please review the contribution guide. Will flag this as needs work until then |
Addressed all the failing tasks, hopefully everything passes this time |
Okay, since i can't get an expected result from the arabic script based regex assertions, they pass on my local ubuntu machine, pass on a local windows machinem, yet i get conflicted resuts from pcre2 regex testers, and don't pass here. and also since they don't prove anything concise, i decided against proving that arabic text is arabic text. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed after 1 week if no further activity occurs. Thank you for your contributions. |
Please ensure it is properly tested |
Like i said, my previous tests (pcre2 regex tests) gave me conflicting results between my local dev machine and here on github. and these tests only proved that Arabic is Arabic, didn't really test something solid. and before that when i took hints from other locales in this library and made similar tests, they were cited to be changed (and rightfully so). don't think i have a valid meaningful way to test that Arabic is Arabic. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed after 1 week if no further activity occurs. Thank you for your contributions. |
@bram-pkg lgtm so far. Can you do a final check? |
What is the reason for this PR?
Adds an Egyptian Arabic (ar_EG) locale
Author's checklist
Summary of changes
as shown in the points above, added locale specific names, and national id number as well as company registration info.
and the all tests are passing
Review checklist