-
Notifications
You must be signed in to change notification settings - Fork 356
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure php 8.1 compatibility #373
Ensure php 8.1 compatibility #373
Conversation
I think this is good for future proofing. |
@GrahamCampbell Changed, thanks! :) |
Requested changes have been applied.
Hey all. Is there anything I can help to do to get this PR moving? PHP 8.1 release date is approaching and atm this is blocking Laravel from offering full PHP 8.1 support. Let me know how I can help! |
Dries, I think this is actually done now. @GrahamCampbell just needs to approve the applied changes after his request. |
Thanks guys :) |
What is the reason for this PR?
phpspec/prophecy
has released version1.14.0
today, which now allows to use the latest tagged phpunit under php 8.1.Author's checklist
Summary of changes
I have added php 8.1 to the test workflow to test new changes with php 8.1 in the future to ensure compatibility. I had to fix some deprecations though in order for phpunit to run successfully.
Review checklist