Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfixes. Add update-cli command #562

Merged
merged 9 commits into from
Apr 1, 2022
Merged

Conversation

sudermanjr
Copy link
Member

Checklist

  • I have signed the CLA
  • I have updated/added any relevant documentation

Description

What's the goal of this PR?

A couple of bugfixes in the golang version from testing. Updated tests. Added an update-cli command

What changes did you make?

  • New command for updating cli
  • Moved git repo clone logic into function and called it from both template and plot
  • Output colorized output to stderr so that reckoner template is more useful

@sudermanjr sudermanjr requested a review from lucasreed as a code owner April 1, 2022 20:03
)

klog.InitFlags(nil)
pflag.CommandLine.AddGoFlag(flag.CommandLine.Lookup("v"))

color.Output = colorable.NewColorableStderr()
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This handles the colorized output to stderr

@sonarqubecloud
Copy link

sonarqubecloud bot commented Apr 1, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@sudermanjr sudermanjr merged commit c5d0d67 into master Apr 1, 2022
@sudermanjr sudermanjr deleted the sudermanjr/update-cmd branch April 1, 2022 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants