[stable/insights-agent]: FWI-3155: Add Trivy unsetAWSRegionEnvVars to help Trivy scan ECR in a different region
#1016
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 15, 2022 14:04
…ivy authenticate to ECR in a different region
Fairwinds Insights CI Report✅ No new Action Items detected! |
ivanfetch-wt
changed the title
unsetAWSRegionEnvVars to help Trivy scan ECR in a different region
rbren
approved these changes
Nov 15, 2022
rbren
approved these changes
Nov 15, 2022
|
I'm closing this in favor of PR #1023 which allows environment variables to be set for Trivy. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why This PR?
FWI-3155 - help Trivy authenticate to ECR when ECR is in a different region, by unsetting
AWS_DEFAULT_REGIONandAWS_REGIONenvironment variables which in turn keep the EKS pod identity WebHook from injecting those same variables based on the cluster's location.A new
Trivy.unsetAWSRegionEnvVarsboolean chart value causes the above environment variables to be unset in the Trivy CronJob. I verified this unsets these environment variables when set statically in a "pretend Trivy" CronJob image, as a test.Checklist:
[stable/goldilocks].Chart.yamlfollowing Semantic Versioning.helm-docs --sort-values-order=filehas been run for the charts that support it.