Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

logging review #80

Merged
merged 2 commits into from
Jan 15, 2020
Merged

logging review #80

merged 2 commits into from
Jan 15, 2020

Conversation

lucasreed
Copy link
Contributor

@lucasreed lucasreed commented Jan 15, 2020

I decided to keep logrus around for now until we can further discuss klog and if we want to change.

@lucasreed lucasreed requested a review from mjhuber as a code owner January 15, 2020 20:07
@codecov
Copy link

codecov bot commented Jan 15, 2020

Codecov Report

Merging #80 into master will increase coverage by 0.12%.
The diff coverage is 61.9%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #80      +/-   ##
==========================================
+ Coverage   55.92%   56.04%   +0.12%     
==========================================
  Files           7        7              
  Lines         456      455       -1     
==========================================
  Hits          255      255              
+ Misses        176      175       -1     
  Partials       25       25
Impacted Files Coverage Δ
pkg/handler/handler.go 52.57% <33.33%> (+0.53%) ⬆️
pkg/handler/deployments.go 51.28% <50%> (ø) ⬆️
pkg/controller/controller.go 39.84% <60%> (ø) ⬆️
pkg/config/config.go 75.19% <83.33%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fcab9e9...5c96e1f. Read the comment docs.

Copy link
Collaborator

@mjhuber mjhuber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@lucasreed lucasreed merged commit b3c1994 into master Jan 15, 2020
@lucasreed lucasreed deleted the lucasreed/logging_review branch January 15, 2020 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants