Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmake: Drop Generate_Version_Info #1377

Merged
merged 1 commit into from
Mar 24, 2023

Conversation

ChristianTackeGSI
Copy link
Member

@ChristianTackeGSI ChristianTackeGSI commented Mar 23, 2023

This is a small step towards #1076

But basically simplify the whole version generation code.

The git-version related stuff will come back quite soon.

For the external users of Generate_Version_Info this is a breaking change:

  • If you just need to generate some files with your version number in it,
    use the standard configure_file CMake command.
  • Alternatively consider creating a proper CMake Package with
    configure_package_config_file(), and write_basic_package_version_file().

Checklist:

@ChristianTackeGSI ChristianTackeGSI changed the base branch from master to dev March 23, 2023 13:45
@ChristianTackeGSI ChristianTackeGSI changed the title Pr/cmake cmake: Drop Generate_Version_Info Mar 23, 2023
@ChristianTackeGSI ChristianTackeGSI added this to the v19.0 milestone Mar 23, 2023
@ChristianTackeGSI ChristianTackeGSI marked this pull request as ready for review March 23, 2023 14:07
@dennisklein dennisklein merged commit bc4f4bb into FairRootGroup:dev Mar 24, 2023
@ChristianTackeGSI ChristianTackeGSI deleted the pr/cmake branch March 24, 2023 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants