Add a large number of convenience functions to Control and cleanup ru… #203
MathiasKochThis workflow graph cannot be shown
A graph will be generated the next time this workflow is run.
Annotations
10 errors and 25 warnings
|
Error
No event triggers defined in `on`
|
|
failed to resolve: use of undeclared type `Digester`:
src/asynch/runner.rs#L104
error[E0433]: failed to resolve: use of undeclared type `Digester`
--> src/asynch/runner.rs:104:13
|
104 | Digester::new(),
| ^^^^^^^^ use of undeclared type `Digester`
|
help: consider importing one of these items
|
1 + use atat::Digester;
|
1 + use crate::atat::Digester;
|
|
|
cannot find value `URC_SUBSCRIBERS` in this scope:
src/asynch/runner.rs#L82
error[E0425]: cannot find value `URC_SUBSCRIBERS` in this scope
--> src/asynch/runner.rs:82:81
|
82 | atat::Ingress<'a, Digester, UbloxUrc, INGRESS_BUF_SIZE, URC_CAPACITY, { URC_SUBSCRIBERS }>,
| ^^^^^^^^^^^^^^^ not found in this scope
|
help: you might be missing a const parameter
|
73 | pub struct Runner<'a, T: Transport, C, const INGRESS_BUF_SIZE: usize, const URC_CAPACITY: usize, const URC_SUBSCRIBERS: /* Type */> {
| +++++++++++++++++++++++++++++++++++
|
|
cannot find type `Digester` in this scope:
src/asynch/runner.rs#L82
error[E0412]: cannot find type `Digester` in this scope
--> src/asynch/runner.rs:82:27
|
82 | atat::Ingress<'a, Digester, UbloxUrc, INGRESS_BUF_SIZE, URC_CAPACITY, { URC_SUBSCRIBERS }>,
| ^^^^^^^^ not found in this scope
|
help: consider importing one of these items
|
1 + use atat::Digester;
|
1 + use crate::atat::Digester;
|
|
|
cannot find value `URC_SUBSCRIBERS` in this scope:
src/asynch/runner.rs#L79
error[E0425]: cannot find value `URC_SUBSCRIBERS` in this scope
--> src/asynch/runner.rs:79:63
|
79 | pub urc_channel: &'a UrcChannel<UbloxUrc, URC_CAPACITY, { URC_SUBSCRIBERS }>,
| ^^^^^^^^^^^^^^^ not found in this scope
|
help: you might be missing a const parameter
|
73 | pub struct Runner<'a, T: Transport, C, const INGRESS_BUF_SIZE: usize, const URC_CAPACITY: usize, const URC_SUBSCRIBERS: /* Type */> {
| +++++++++++++++++++++++++++++++++++
|
|
cannot find value `URC_SUBSCRIBERS` in this scope:
src/asynch/runner.rs#L51
error[E0425]: cannot find value `URC_SUBSCRIBERS` in this scope
--> src/asynch/runner.rs:51:11
|
51 | { URC_SUBSCRIBERS },
| ^^^^^^^^^^^^^^^ not found in this scope
|
help: you might be missing a const parameter
|
42 | async fn at_bridge<'a, const INGRESS_BUF_SIZE: usize, const URC_CAPACITY: usize, const URC_SUBSCRIBERS: /* Type */>(
| +++++++++++++++++++++++++++++++++++
|
|
cannot find type `Digester` in this scope:
src/asynch/runner.rs#L47
error[E0412]: cannot find type `Digester` in this scope
--> src/asynch/runner.rs:47:9
|
47 | Digester,
| ^^^^^^^^ not found in this scope
|
help: consider importing one of these items
|
1 + use atat::Digester;
|
1 + use crate::atat::Digester;
|
|
|
unresolved import `super::runner::URC_SUBSCRIBERS`:
src/asynch/resources.rs#L5
error[E0432]: unresolved import `super::runner::URC_SUBSCRIBERS`
--> src/asynch/resources.rs:5:27
|
5 | runner::{MAX_CMD_LEN, URC_SUBSCRIBERS},
| ^^^^^^^^^^^^^^^ no `URC_SUBSCRIBERS` in `asynch::runner`
|
note: found an item that was configured out
--> src/asynch/runner.rs:31:18
|
31 | pub(crate) const URC_SUBSCRIBERS: usize = 2;
| ^^^^^^^^^^^^^^^
= note: the item is gated behind the `ppp` feature
note: found an item that was configured out
--> src/asynch/runner.rs:36:18
|
36 | pub(crate) const URC_SUBSCRIBERS: usize = 3;
| ^^^^^^^^^^^^^^^
= note: the item is gated behind the `internal-network-stack` feature
|
|
unresolved import `super::runner::URC_SUBSCRIBERS`:
src/asynch/network.rs#L29
error[E0432]: unresolved import `super::runner::URC_SUBSCRIBERS`
--> src/asynch/network.rs:29:13
|
29 | use super::{runner::URC_SUBSCRIBERS, state, UbloxUrc};
| ^^^^^^^^^^^^^^^^^^^^^^^ no `URC_SUBSCRIBERS` in `asynch::runner`
|
note: found an item that was configured out
--> src/asynch/runner.rs:31:18
|
31 | pub(crate) const URC_SUBSCRIBERS: usize = 2;
| ^^^^^^^^^^^^^^^
= note: the item is gated behind the `ppp` feature
note: found an item that was configured out
--> src/asynch/runner.rs:36:18
|
36 | pub(crate) const URC_SUBSCRIBERS: usize = 3;
| ^^^^^^^^^^^^^^^
= note: the item is gated behind the `internal-network-stack` feature
|
|
unresolved import `super::runner::URC_SUBSCRIBERS`:
src/asynch/control.rs#L51
error[E0432]: unresolved import `super::runner::URC_SUBSCRIBERS`
--> src/asynch/control.rs:51:34
|
51 | use super::runner::{MAX_CMD_LEN, URC_SUBSCRIBERS};
| ^^^^^^^^^^^^^^^ no `URC_SUBSCRIBERS` in `asynch::runner`
|
note: found an item that was configured out
--> src/asynch/runner.rs:31:18
|
31 | pub(crate) const URC_SUBSCRIBERS: usize = 2;
| ^^^^^^^^^^^^^^^
= note: the item is gated behind the `ppp` feature
note: found an item that was configured out
--> src/asynch/runner.rs:36:18
|
36 | pub(crate) const URC_SUBSCRIBERS: usize = 3;
| ^^^^^^^^^^^^^^^
= note: the item is gated behind the `internal-network-stack` feature
|
|
unused import: `AtatIngress`:
src/asynch/runner.rs#L23
warning: unused import: `AtatIngress`
--> src/asynch/runner.rs:23:5
|
23 | AtatIngress as _, UrcChannel,
| ^^^^^^^^^^^
|
|
unused variable: `psk`:
src/asynch/control.rs#L512
warning: unused variable: `psk`
--> src/asynch/control.rs:512:41
|
512 | WifiAuthentication::Wpa2Psk(psk) => {
| ^^^ help: if this is intentional, prefix it with an underscore: `_psk`
|
|
unreachable call:
src/asynch/control.rs#L523
warning: unreachable call
--> src/asynch/control.rs:523:39
|
523 | config_param: WifiStationConfig::WpaPskOrPassphrase(todo!("hex values?!")),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ --------------------- any code following this expression is unreachable
| |
| unreachable call
|
= note: `#[warn(unreachable_code)]` on by default
|
|
unused variable: `channel`:
src/asynch/control.rs#L440
warning: unused variable: `channel`
--> src/asynch/control.rs:440:73
|
440 | pub async fn start_ap_wpa2(&mut self, ssid: &str, passphrase: &str, channel: u8) {
| ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_channel`
|
|
unused variable: `passphrase`:
src/asynch/control.rs#L440
warning: unused variable: `passphrase`
--> src/asynch/control.rs:440:55
|
440 | pub async fn start_ap_wpa2(&mut self, ssid: &str, passphrase: &str, channel: u8) {
| ^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_passphrase`
|
|
unused variable: `ssid`:
src/asynch/control.rs#L440
warning: unused variable: `ssid`
--> src/asynch/control.rs:440:43
|
440 | pub async fn start_ap_wpa2(&mut self, ssid: &str, passphrase: &str, channel: u8) {
| ^^^^ help: if this is intentional, prefix it with an underscore: `_ssid`
|
|
unused variable: `channel`:
src/asynch/control.rs#L435
warning: unused variable: `channel`
--> src/asynch/control.rs:435:55
|
435 | pub async fn start_ap_open(&mut self, ssid: &str, channel: u8) {
| ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_channel`
|
|
unused variable: `ssid`:
src/asynch/control.rs#L435
warning: unused variable: `ssid`
--> src/asynch/control.rs:435:43
|
435 | pub async fn start_ap_open(&mut self, ssid: &str, channel: u8) {
| ^^^^ help: if this is intentional, prefix it with an underscore: `_ssid`
|
= note: `#[warn(unused_variables)]` on by default
|
|
long literal lacking separators:
src/command/system/types.rs#L122
warning: long literal lacking separators
--> src/command/system/types.rs:122:16
|
122 | B5250000 = 5250000,
| ^^^^^^^ help: consider: `5_250_000`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
|
|
long literal lacking separators:
src/command/system/types.rs#L121
warning: long literal lacking separators
--> src/command/system/types.rs:121:16
|
121 | B3000000 = 3000000,
| ^^^^^^^ help: consider: `3_000_000`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
|
|
long literal lacking separators:
src/command/system/types.rs#L120
warning: long literal lacking separators
--> src/command/system/types.rs:120:15
|
120 | B921600 = 921600,
| ^^^^^^ help: consider: `921_600`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
|
|
long literal lacking separators:
src/command/system/types.rs#L119
warning: long literal lacking separators
--> src/command/system/types.rs:119:15
|
119 | B460800 = 460800,
| ^^^^^^ help: consider: `460_800`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
|
|
long literal lacking separators:
src/command/system/types.rs#L118
warning: long literal lacking separators
--> src/command/system/types.rs:118:15
|
118 | B250000 = 250000,
| ^^^^^^ help: consider: `250_000`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
|
|
long literal lacking separators:
src/command/system/types.rs#L117
warning: long literal lacking separators
--> src/command/system/types.rs:117:15
|
117 | B230400 = 230400,
| ^^^^^^ help: consider: `230_400`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
|
|
long literal lacking separators:
src/command/system/types.rs#L116
warning: long literal lacking separators
--> src/command/system/types.rs:116:15
|
116 | B115200 = 115200,
| ^^^^^^ help: consider: `115_200`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
|
|
long literal lacking separators:
src/command/system/types.rs#L69
warning: long literal lacking separators
--> src/command/system/types.rs:69:15
|
69 | B460800 = 460800,
| ^^^^^^ help: consider: `460_800`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
|
|
long literal lacking separators:
src/command/system/types.rs#L68
warning: long literal lacking separators
--> src/command/system/types.rs:68:15
|
68 | B230400 = 230400,
| ^^^^^^ help: consider: `230_400`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
|
|
long literal lacking separators:
src/command/system/types.rs#L67
warning: long literal lacking separators
--> src/command/system/types.rs:67:15
|
67 | B115200 = 115200,
| ^^^^^^ help: consider: `115_200`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
= note: `-W clippy::unreadable-literal` implied by `-W clippy::pedantic`
= help: to override `-W clippy::pedantic` add `#[allow(clippy::unreadable_literal)]`
|
|
unused import: `Duration`:
src/asynch/runner.rs#L27
warning: unused import: `Duration`
--> src/asynch/runner.rs:27:20
|
27 | use embassy_time::{Duration, Timer};
| ^^^^^^^^
|
|
unused import: `SimpleClient`:
src/asynch/runner.rs#L22
warning: unused import: `SimpleClient`
--> src/asynch/runner.rs:22:31
|
22 | asynch::{AtatClient as _, SimpleClient},
| ^^^^^^^^^^^^
|
|
unused imports: `ChangeMode`, `self`:
src/asynch/runner.rs#L5
warning: unused imports: `ChangeMode`, `self`
--> src/asynch/runner.rs:5:21
|
5 | data_mode::{self, ChangeMode},
| ^^^^ ^^^^^^^^^^
|
|
redundant else block:
src/asynch/control.rs#L458
warning: redundant else block
--> src/asynch/control.rs:458:20
|
458 | } else {
| ____________________^
459 | | self.leave().await?;
460 | | };
| |_____________^
|
= help: remove the `else` block and move the contents out
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_else
= note: `-W clippy::redundant-else` implied by `-W clippy::pedantic`
= help: to override `-W clippy::pedantic` add `#[allow(clippy::redundant_else)]`
|
|
redundant field names in struct initialization:
src/asynch/control.rs#L151
warning: redundant field names in struct initialization
--> src/asynch/control.rs:151:13
|
151 | urc_channel: urc_channel,
| ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `urc_channel`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
= note: `-W clippy::redundant-field-names` implied by `-W clippy::all`
= help: to override `-W clippy::all` add `#[allow(clippy::redundant_field_names)]`
|
|
unused import: `crate::command::ping::Ping`:
src/asynch/control.rs#L20
warning: unused import: `crate::command::ping::Ping`
--> src/asynch/control.rs:20:5
|
20 | use crate::command::ping::Ping;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= note: `#[warn(unused_imports)]` on by default
|
|
found an empty line after a doc comment. Perhaps you need to use `//!` to make a comment on a module, remove the empty line, or make a regular comment with `//`?:
src/command/ping/types.rs#L25
warning: found an empty line after a doc comment. Perhaps you need to use `//!` to make a comment on a module, remove the empty line, or make a regular comment with `//`?
--> src/command/ping/types.rs:25:1
|
25 | / /// - Default value: 1000
26 | | // pub type Interval = u16;
27 | |
28 | | #[derive(Debug, PartialEq, Clone, Copy, AtatEnum)]
29 | | #[cfg_attr(feature = "defmt", derive(defmt::Format))]
30 | | #[repr(u8)]
31 | | pub enum PingError {
| |_
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments
= note: `-W clippy::empty-line-after-doc-comments` implied by `-W clippy::nursery`
= help: to override `-W clippy::nursery` add `#[allow(clippy::empty_line_after_doc_comments)]`
|