-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add FeatureSet
class for holding information about mapping format capabilities
#92
Add FeatureSet
class for holding information about mapping format capabilities
#92
Conversation
For FeatureSet: since mapping format is mainly used on reader/writer end of the visitor chain, can't this just be replaced by extra mapping flags? |
The main motivation behind this addition is to allow for programmatic querying of format features. See |
This reverts commit 046ca1f.
The tests are only failing because of #97, apart from that everything works fine |
MappingFormat$FeatureSet
FeatureSet
class for holding information about mapping format capabilities
src/main/java/net/fabricmc/mappingio/format/FeatureSetImpl.java
Outdated
Show resolved
Hide resolved
One last question @liach: Would you prefer Edit: After consulting Player, I decided to go with |
JDK prefers no get prefix, but prefers to follow existing style (such as return List vs array, existing get prefix in java.lang.Class). I think get is for mutable properties (not recommended nowadays) while record-style is for immutable. |
Mapping formats now have an associated
FeatureSet
instance, which provides much improved feature support declaration capabilities compared to the existing booleans.