Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix AFTER_SETUP event not being able to render #4219

Merged
merged 8 commits into from
Nov 25, 2024
Merged

Fix AFTER_SETUP event not being able to render #4219

merged 8 commits into from
Nov 25, 2024

Conversation

JustRed23
Copy link
Contributor

@JustRed23 JustRed23 commented Nov 9, 2024 •
edited
Loading

Due to 1.21.2 changing the way how level rendering works, adding a RenderSystem.clear after the AFTER_SETUP event, rendering is not possible with this event, so I moved the event to a later point after the clear call but before the terrain rendering

@AsynchronousAI
Copy link

LGTM!

modmuss50
modmuss50 requested changes Nov 18, 2024
View reviewed changes
Copy link
Member

@modmuss50 modmuss50 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was pointed out to me on discord that the old API is broken, this should be fixed to work as it did it before (or as close to it). There is no point adding a new api and leaving a broken API in its place.

@JustRed23 JustRed23 changed the title Add BEFORE_TERRAIN world render event Fix AFTER_SETUP event not being able to render Nov 18, 2024
@JustRed23
Copy link
Contributor Author

It was pointed out to me on discord that the old API is broken, this should be fixed to work as it did it before (or as close to it). There is no point adding a new api and leaving a broken API in its place.

Removed new event, fixed existing event

@modmuss50 modmuss50 added bug Something isn't working last call If you care, make yourself heard right away! small change labels Nov 18, 2024
@modmuss50 modmuss50 merged commit 6922831 into FabricMC:1.21.3 Nov 25, 2024
4 checks passed
modmuss50 pushed a commit that referenced this pull request Nov 25, 2024
@JustRed23 @modmuss50
Fix AFTER_SETUP event not being able to render (#4219)
6dc662b 
* Add BEFORE_TERRAIN world render event

* Add 1.21.2 rendering issue warning

* Add comment to injection point

* close b tag

* Undo all new event changes

* Move AFTER_SETUP event to new mixin

* Remove event interface

* Refine mixin

(cherry picked from commit 6922831)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AsynchronousAI AsynchronousAI AsynchronousAI left review comments

@watertrainer watertrainer watertrainer left review comments

@Juuxel Juuxel Juuxel left review comments

@Chocohead Chocohead Chocohead left review comments

@Alexander01998 Alexander01998 Alexander01998 approved these changes

@Verteiron Verteiron Verteiron approved these changes

@modmuss50 modmuss50 modmuss50 approved these changes

Assignees
No one assigned
Labels
bug Something isn't working last call If you care, make yourself heard right away! small change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@JustRed23 @AsynchronousAI @Chocohead @modmuss50 @Verteiron @Juuxel @Alexander01998 @watertrainer