Add ServerChunkEvents.Generate #4183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…when a chunk is first upgraded to full status
|
Please add a tests for this, fine if its something simple such as a long line or maybe place a block somewhere. |
After creating an SP world and waiting for all nearby chunks to generate (logging to stop), closing the SP world and opening it again should not log any fresh generation. Moving to an unexplored area will start logging again.
|
I've added a simple logging-based test with instructions to verify behavior in the Javadoc. |
modmuss50
approved these changes
Oct 24, 2024
modmuss50
added
last call
modmuss50
pushed a commit
that referenced
this pull request
Oct 26, 2024
* Add a new chunk generate event, fired alongside the chunk load event when a chunk is first upgraded to full status * fix style * Add logging test for generate event After creating an SP world and waiting for all nearby chunks to generate (logging to stop), closing the SP world and opening it again should not log any fresh generation. Moving to an unexplored area will start logging again. (cherry picked from commit 4402f4e)
ishland
added a commit
to RelativityMC/C2ME-fabric
that referenced
this pull request
Oct 27, 2024
ishland
added a commit
to RelativityMC/C2ME-fabric
that referenced
this pull request
Oct 27, 2024
ishland
added a commit
to RelativityMC/C2ME-neoforge
that referenced
this pull request
Oct 28, 2024
Upstream has released updates that appear to apply and compile correctly Upstream Changes: f9c250b3 new: call ServerChunkEvents.CHUNK_GENERATE (FabricMC/fabric#4183)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a new chunk generate event, fired alongside the chunk load event when a chunk is first upgraded to full status.
My use case for this is a world map mod, I need to know when new chunks are generated to map them. I don't need to map a chunk that is just loading, only generated, I have other hooks to re-map chunks when blocks change.
Until now I've used a mixin to accomplish this, however, this makes compatibility more difficult with mods like Moonrise that rewrite the chunk system.
Some additional context (Mojang mappings):