Fix After Translucent World Render Event #4155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Does this also apply to 1.21.1 or did it break during the 1.21.2 update? |
|
@modmuss50 From the diff I believe this broke in 1.21.2 cycle. Not tested though. |
The event works fine in 1.21.1, it only broke in 1.21.2 with the introduction of the frame graph and render pass stuff. |
|
Ok, perfect thanks. |
modmuss50
approved these changes
Oct 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the
AFTER_TRANSLUCENTworld render event not working due to it not being attached to any render pass, which also caused the test mod to crash.Also fixes the test mod using the wrong box drawing method and added some further specifications as to the exact type of box that should be rendered.