ステップ10: タスク一覧を作成日時の順番で並び替えましょう #928
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kotaro0522
reviewed
Mar 4, 2021
yaraneba/.rubocop.yml
Outdated
Comment on lines
5
to
7
| Rails/DynamicFindBy: | ||
| Whitelist: | ||
| - find_by_id |
There was a problem hiding this comment.
h ttps://github.com/rubocop/rubocop-jp/issues/ 54
Excludeパラメータで指定すると良さそうです。
kotaro0522
reviewed
Mar 4, 2021
| @@ -5,7 +5,7 @@ class TasksController < ApplicationController | |||
|
|
|||
| # GET /tasks or /tasks.json | |||
| def index | |||
| @tasks = Task.all | |||
| @tasks = Task.all.order(created_at: 'DESC') | |||
There was a problem hiding this comment.
ただの好みなんですが、自分は order(created_at: :desc) か order('created_at DESC') って書きたいかなと思いました。
（ラクマ のソースコードはそうなってることが多いです。）
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
参考: rails研修 step10
環境構築方法
環境構築でエラーが発生した際もお申し付けください。
実施内容
確認事項
画面
spec実行
rubocop実行
