Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update webmock to fix specs #14

Merged
merged 8 commits into from
Feb 21, 2020

Conversation

kalilz4485
Copy link
Contributor

Current version of webmock doesn't support ruby >= 2.4.0

We got this error

before_faye

source: bblimke/webmock#683

After update

after_faye

Took latest released version.

@jarthod
Copy link
Collaborator

jarthod commented Feb 7, 2020

Thanks, could you please update the travis test matrix then? because it's testing with old ruby currently and it fails ;)

@kalilz4485
Copy link
Contributor Author

rspec is ok but jasmine if full bug since WWI

I'll have a look at it at some point

@jarthod
Copy link
Collaborator

jarthod commented Feb 7, 2020

Ok thanks!

@kalilz4485
Copy link
Contributor Author

Travis seems ok now

@jarthod jarthod merged commit b533dd1 into FabienChaynes:master Feb 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants