-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update webmock to fix specs #14
Merged
jarthod
merged 8 commits into
FabienChaynes:master
from
kalilz4485:fix-specs-webmock-update
Feb 21, 2020
Merged
Update webmock to fix specs #14
jarthod
merged 8 commits into
FabienChaynes:master
from
kalilz4485:fix-specs-webmock-update
Feb 21, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks, could you please update the travis test matrix then? because it's testing with old ruby currently and it fails ;) |
rspec is ok but jasmine if full bug since WWI I'll have a look at it at some point |
Ok thanks! |
kalilz4485
commented
Feb 21, 2020
kalilz4485
commented
Feb 21, 2020
kalilz4485
commented
Feb 21, 2020
kalilz4485
commented
Feb 21, 2020
kalilz4485
commented
Feb 21, 2020
kalilz4485
commented
Feb 21, 2020
Travis seems ok now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current version of webmock doesn't support ruby >= 2.4.0
We got this error
source: bblimke/webmock#683
After update
Took latest released version.