Add missing mutex lock #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The functions *Sentinel.putToTop and *Sentinel.putToBottom were meant to be called with the *Sentinel.mu mutex held. However, putToTop was being called _without_ holding the mutex. This commit moves the locking/unlocking into the helper functions so that the caller cannot forget to lock. While we are here, we simplify the helper functions.
jacobvosmaer
force-pushed
the
jv-locking
branch
from
50a6d3e to
62f0f83
Compare
jacobvosmaer
commented
Sep 13, 2022
| s.putToBottom(addr) | ||
| s.mu.Unlock() | ||
| continue | ||
| } | ||
| s.putToTop(addr) |
There was a problem hiding this comment.
This is the only call site of putToTop and as you can see, we don't hold the mutex when calling it.
|
Hello @jacobvosmaer, many thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The functions
*Sentinel.putToTopand*Sentinel.putToBottomare meant to be called with the*Sentinel.mumutex held. However,putToTopwas being called without holding the mutex. This commit moves the locking/unlocking into the helper functions so that the caller cannot forget to lock.While we are here, we simplify the helper functions.