Use correct replace method when SEG is String #678
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This method calls ReadOnlyStyledDocument.fromString as opposed to ReadOnlyStyledDocument.fromSeg
|
I think I will wait to merge this until I hear back from Jugen in #656. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #676.
In addition to fixing that issue, I also bumped the type of the area's segmentOps field from
SegmentOpstoTextOps. The area's constructor already requires the latter type, so this just makes it easier to callStyledDocument-related methods.It is unlikely for this bug to be reproduced in the other areas because their SEG generic isn't purely text. Still, I wonder whether the method names should be changed to prevent problems like this from arising in the future. I think one test that could be written for this would be to check the number of visible paragraphs after constructing each kind of area.