-
Notifications
You must be signed in to change notification settings - Fork 236
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Is it possible to add OSGI support? #570
Comments
Mind submitting a PR for that? You'll still need to build RichTextFX with
Jitpack.
…On Aug 25, 2017 7:02 AM, "PashaTurok" ***@***.***> wrote:
You library is wonderful. But it is not OSGI. Of course it is possible to
download the source code and add it to osgi project but then it must be
done for every release. Could you add OSGI support?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#570>, or mute the thread
<https://github.com/notifications/unsubscribe-auth/AIBfbWEtc6tvibuYEo1dlicTX3idgUZzks5sbtP1gaJpZM4PCs8q>
.
|
@JordanMartinez I work only with maven and know how to build osgi bundles using maven. I can add parent pom and child pom both to this project and to ReactFX, if you approve the idea. |
@PashaTurok I only have write access to RichTextFX, not ReactFX. So, while I could add it here, it wouldn't be the case for ReactFX. Even if you or I did submit a PR for OSGI on ReactFX, Tomas hasn't merged other PRs I have made months ago. You'd be better off creating your own fork, adding it there, and using that is RichTextFX's dependency instead of it's default one. |
@TomasMikula Could you say if you will allow to add POMs with OSGi support to both projects? |
RichTextFX library is wonderful. But it is not OSGI. Of course it is possible to download the source code and add it to osgi project but then it must be done for every release. Is it possible to add OSGI support?
The text was updated successfully, but these errors were encountered: