Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is it possible to add OSGI support? #570

Closed
PavelTurk opened this issue Aug 25, 2017 · 4 comments
Closed

Is it possible to add OSGI support? #570

PavelTurk opened this issue Aug 25, 2017 · 4 comments

Comments

@PavelTurk
Copy link
Contributor

PavelTurk commented Aug 25, 2017

RichTextFX library is wonderful. But it is not OSGI. Of course it is possible to download the source code and add it to osgi project but then it must be done for every release. Is it possible to add OSGI support?

@PavelTurk PavelTurk changed the title Could you add OSGI support? Is it possible to add OSGI support? Aug 25, 2017
@JordanMartinez
Copy link
Contributor

JordanMartinez commented Aug 25, 2017 via email

@PavelTurk
Copy link
Contributor Author

@JordanMartinez I work only with maven and know how to build osgi bundles using maven. I can add parent pom and child pom both to this project and to ReactFX, if you approve the idea.

@JordanMartinez
Copy link
Contributor

@PashaTurok I only have write access to RichTextFX, not ReactFX. So, while I could add it here, it wouldn't be the case for ReactFX. Even if you or I did submit a PR for OSGI on ReactFX, Tomas hasn't merged other PRs I have made months ago. You'd be better off creating your own fork, adding it there, and using that is RichTextFX's dependency instead of it's default one.

@PavelTurk
Copy link
Contributor Author

@TomasMikula Could you say if you will allow to add POMs with OSGi support to both projects?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants