krml/Makefiles: unifying logic for detecting F* #512
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mostly preparing for using F* outside of a repo, i.e. without an FSTAR_HOME. The Makefiles and krml will now only locate fstar.exe, and call it to find its library and OCaml files. To find fstar.exe, the process is: - First try to read the environment variable FSTAR_EXE. - If unset, try FSTAR_HOME/bin/fstar.exe (for compatibility) - If FSTAR_HOME is unset, check the PATH.
Personally I think it's more complicated than necessary. In virtually all cases you want to have |
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mostly preparing for using F* outside of a repo, i.e. without an FSTAR_HOME. The Makefiles and krml will now only locate fstar.exe, and call it to find its library and OCaml files. To find fstar.exe, the process is:
(I'm proposing other projects should use that logic too.. does it make sense? Steel is already doing via this same
locate_fstar.mk)