Allow use_hints even when context_pruning is set #3703
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtzguido
force-pushed
the
_nik_hints_with_context_pruning
branch
from
421b821 to
13a2b89
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Probably shouldn't have disabled use_hints when context_pruning is set, in the first place.
Now the behavior is that if you have both
--use_hints --ext context_pruning, we will try to first prove the query in a fresh Z3 context with the recorded unsat core in the hints file.If that fails, we fall back to trying the query in the background incremental solver, but this time we will prune the context before trying the query.
check-world works: https://github.com/FStarLang/FStar/actions/runs/13054935803