This repository has been archived by the owner on Sep 24, 2022. It is now read-only.
Replace IOLoop.update_handler with remove_handler and add_handler #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g in tornado.gen in the host application to the extend that the errors were returned on the wrong RequestHandler. I assume it has something to do with the StackContext.
FSX
added a commit
that referenced
this pull request
Jan 6, 2013
Replace IOLoop.update_handler with remove_handler and add_handler
|
Thanks! :) |
|
Hey, I made a few changes your pull request after I looked at the code more carefully. Here's the commit, everything is explained in the commit message: 92940db. It's in the |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using IOLoop.update_handler was causing issues with Exception handling in tornado.gen in the host application to the extend that the errors were returned on the wrong RequestHandler. Even other code errors. I assume it has something to do with the StackContext. add_handler creates a new StackContext, but update_handler doesn't.