bgpd: Use strict AS4 capability when processing parsing/generating pkts #9249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PeerA sets `dont-capability-negotiate` for PeerB. It does not send any capabilities to PeerB. This leads to situation when PeerA received AS4 cap, while it doesn't send AS4 to PeerB and tries parsing AS_PATH using 32bits. [GTTPK-RX2GP][EC 33554436] Malformed AS path from 192.168.0.2, length is 4 [SM0KX-WXMGK] bgp_attr_malformed: attributes: , origin ? [P7TRR-4J6XT][EC 33554487] 192.168.0.2: Attribute AS_PATH, parse error - treating as withdrawal [WX70K-6XXVF][EC 33554454] 192.168.0.2 rcvd UPDATE with errors in attr(s)!! Withdrawing route. [Z2KFR-ZGJC8] 192.168.0.2 rcvd UPDATE w/ attr: , origin ? [P9VY3-5B6NX] 192.168.0.2 rcvd UPDATE wlen 0 attrlen 80 alen 73 [QMZ79-K2DH7][EC 33554454] 192.168.0.2 [Error] Update packet error (wrong prefix length 64 for afi 1) [P9SYB-54XRZ][EC 33554454] 192.168.0.2 [Error] Error parsing NLRI [V1CHF-JSGRR] %NOTIFICATION: sent to neighbor 192.168.0.2 3/10 (UPDATE Message Error/Invalid Network Field) 0 bytes [HTHRX-GQYGJ][EC 33554454] bgp_process_packet: BGP UPDATE receipt failed for peer: 192.168.0.2 Signed-off-by: Donatas Abraitis <[email protected]>
Signed-off-by: Donatas Abraitis <[email protected]>
|
@Mergifyio backport stable/8.0 |
|
Command
|
💚 Basic BGPD CI results: SUCCESS, 0 tests failedResults table
For details, please contact louberger |
Continuous Integration Result: SUCCESSFULCongratulations, this patch passed basic tests Tested-by: NetDEF / OpenSourceRouting.org CI System CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-20686/ This is a comment from an automated CI system. |
|
Command
|
donaldsharp
added a commit
that referenced
this pull request
Aug 7, 2021
bgpd: Use strict AS4 capability when processing parsing/generating pkts (backport #9249)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.