Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bgpd: [8.0] BGP dampening backports #9245

Merged
merged 3 commits into from
Aug 3, 2021
Merged

bgpd: [8.0] BGP dampening backports #9245

merged 3 commits into from
Aug 3, 2021

Conversation

ton31337
Copy link
Member

No description provided.

idryzhov added 2 commits July 30, 2021 17:42
@idryzhov @ton31337
bgpd: fix incorrect usage of slist in dampening
0bbfe8d 
Current code is a complete misuse of SLIST structure. Instead of just
adding a SLIST_ENTRY to struct bgp_damp_info, it allocates a separate
structure to be a node in the list.

Signed-off-by: Igor Ryzhov <[email protected]>
@idryzhov @ton31337
bgpd: cleanup bgp_damp_info_free
9a83f48 
bgp_damp_config, afi and safi are never used.

Signed-off-by: Igor Ryzhov <[email protected]>
@ton31337 ton31337 force-pushed the fix/backport_9217 branch from 3bd351f to 9a83f48 Compare July 30, 2021 14:43
@LabN-CI
Copy link
Collaborator

LabN-CI commented Jul 30, 2021

💚 Basic BGPD CI results: SUCCESS, 0 tests failed

Results table
_ _
Result SUCCESS git merge/9245 9a83f48
Date 07/30/2021
Start 10:51:17
Finish 11:16:58
Run-Time 25:41
Total 1813
Pass 1813
Fail 0
Valgrind-Errors
Valgrind-Loss
Details vncregress-2021-07-30-10:51:17.txt
Log autoscript-2021-07-30-10:52:27.log.bz2
Memory 484 484 423

For details, please contact louberger

@NetDEF-CI
Copy link
Collaborator

NetDEF-CI commented Jul 30, 2021 •
edited
Loading

Continuous Integration Result: FAILED

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-20668/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Failed

Debian 10 amd64 build: Failed (click for details) Debian 10 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-20668/artifact/DEB10BUILD/config.log/config.log.gz

Make failed for Debian 10 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-20668/artifact/DEB10BUILD/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.20668/frr-source'
bgpd/bgp_damp.c: In function bgp_reuse_timer:
bgpd/bgp_damp.c:191:2: error: node undeclared (first use in this function); did you mean modf?
bgpd/bgp_damp.c:191:2: note: each undeclared identifier is reported only once for each function it appears in
make[1]: *** [Makefile:9738: bgpd/bgp_damp.o] Error 1
copying selected object files to avoid basename conflicts...
make[1]: Leaving directory '/home/ci/cibuild.20668/frr-source'
make[1]: Target 'all-am' not remade because of errors.
make: *** [Makefile:6017: all] Error 2

Debian 10 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-20668/artifact/DEB10BUILD/config.status/config.status

FreeBSD 11 amd64 build: Failed (click for details)

Make failed for FreeBSD 11 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-20668/artifact/CI009BUILD/ErrorLog/log_make.txt)

/usr/home/ci/cibuild.20668/frr-source/doc/user/zebra.rst:1183: WARNING: duplicate clicmd description of debug zebra pbr, other instance in pbr
bgpd/bgp_damp.c: In function 'bgp_reuse_timer':
bgpd/bgp_damp.c:191:2: error: 'node' undeclared (first use in this function)
bgpd/bgp_damp.c:191:2: note: each undeclared identifier is reported only once for each function it appears in
gmake[1]: *** [Makefile:9740: bgpd/bgp_damp.o] Error 1
copying selected object files to avoid basename conflicts...
gmake[1]: Leaving directory '/usr/home/ci/cibuild.20668/frr-source'
gmake[1]: Target 'all-am' not remade because of errors.
gmake: *** [Makefile:6019: all] Error 2

FreeBSD 11 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-20668/artifact/CI009BUILD/config.status/config.status
FreeBSD 11 amd64 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-20668/artifact/CI009BUILD/config.log/config.log.gz

Fedora 29 amd64 build: Failed (click for details)

Make failed for Fedora 29 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-20668/artifact/F29BUILD/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.20668/frr-source'
bgpd/bgp_damp.c: In function bgp_reuse_timer:
bgpd/bgp_damp.c:191:2: error: node undeclared (first use in this function); did you mean modf?
bgpd/bgp_damp.c:191:2: note: each undeclared identifier is reported only once for each function it appears in
make[1]: *** [Makefile:9737: bgpd/bgp_damp.o] Error 1
copying selected object files to avoid basename conflicts...
make[1]: Target 'all-am' not remade because of errors.
make[1]: Leaving directory '/home/ci/cibuild.20668/frr-source'
make: *** [Makefile:6016: all] Error 2

Fedora 29 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-20668/artifact/F29BUILD/config.status/config.status
Fedora 29 amd64 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-20668/artifact/F29BUILD/config.log/config.log.gz

Ubuntu 18.04 arm8 build: Failed (click for details) Ubuntu 18.04 arm8 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-20668/artifact/U18ARM8BUILD/config.status/config.status Ubuntu 18.04 arm8 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-20668/artifact/U18ARM8BUILD/config.log/config.log.gz

Make failed for Ubuntu 18.04 arm8 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-20668/artifact/U18ARM8BUILD/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.20668/frr-source'
bgpd/bgp_damp.c: In function bgp_reuse_timer:
bgpd/bgp_damp.c:191:2: error: node undeclared (first use in this function); did you mean modf?
bgpd/bgp_damp.c:191:2: note: each undeclared identifier is reported only once for each function it appears in
Makefile:9123: recipe for target 'bgpd/bgp_damp.o' failed
make[1]: *** [bgpd/bgp_damp.o] Error 1
copying selected object files to avoid basename conflicts...
make[1]: Target 'all-am' not remade because of errors.
make[1]: Leaving directory '/home/ci/cibuild.20668/frr-source'
OpenBSD 6 amd64 build: Failed (click for details)

Make failed for OpenBSD 6 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-20668/artifact/CI011BUILD/ErrorLog/log_make.txt)

/home/ci/cibuild.20668/frr-source/doc/user/zebra.rst:23: SEVERE: Duplicate ID: "cmdoption-configure-arg-net".
/home/ci/cibuild.20668/frr-source/doc/user/zebra.rst:23: SEVERE: Duplicate ID: "cmdoption-configure-arg-net".
bgpd/bgp_damp.c:191:2: error: use of undeclared identifier 'node'
1 error generated.
gmake[1]: *** [Makefile:9736: bgpd/bgp_damp.o] Error 1
copying selected object files to avoid basename conflicts...
gmake[1]: Target 'all-am' not remade because of errors.
gmake[1]: Leaving directory '/home/ci/cibuild.20668/frr-source'
gmake: *** [Makefile:6015: all] Error 2

OpenBSD 6 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-20668/artifact/CI011BUILD/config.status/config.status
OpenBSD 6 amd64 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-20668/artifact/CI011BUILD/config.log/config.log.gz

CentOS 7 amd64 build: Failed (click for details)

Make failed for CentOS 7 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-20668/artifact/CI005BUILD/ErrorLog/log_make.txt)

make  all-am
make[1]: Entering directory `/home/ci/cibuild.20668/frr-source'
deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.  CC       bgpd/bgp_addpath.o
deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed./home/ci/cibuild.20668/frr-source/doc/user/zebra.rst:23: SEVERE: Duplicate ID: "cmdoption-configure-arg-net".
/home/ci/cibuild.20668/frr-source/doc/user/zebra.rst:23: SEVERE: Duplicate ID: "cmdoption-configure-arg-net".
/home/ci/cibuild.20668/frr-source/doc/user/zebra.rst:23: SEVERE: Duplicate ID: "cmdoption-configure-arg-net".
bgpd/bgp_damp.c: In function bgp_reuse_timer:
bgpd/bgp_damp.c:191:2: error: node undeclared (first use in this function)
bgpd/bgp_damp.c:191:2: note: each undeclared identifier is reported only once for each function it appears in

CentOS 7 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-20668/artifact/CI005BUILD/config.status/config.status
CentOS 7 amd64 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-20668/artifact/CI005BUILD/config.log/config.log.gz

Ubuntu 18.04 i386 build: Failed (click for details) Ubuntu 18.04 i386 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-20668/artifact/U18I386BUILD/config.log/config.log.gz Ubuntu 18.04 i386 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-20668/artifact/U18I386BUILD/config.status/config.status

Make failed for Ubuntu 18.04 i386 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-20668/artifact/U18I386BUILD/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.20668/frr-source'
bgpd/bgp_damp.c: In function bgp_reuse_timer:
bgpd/bgp_damp.c:191:2: error: node undeclared (first use in this function); did you mean modf?
bgpd/bgp_damp.c:191:2: note: each undeclared identifier is reported only once for each function it appears in
Makefile:9123: recipe for target 'bgpd/bgp_damp.o' failed
make[1]: *** [bgpd/bgp_damp.o] Error 1
copying selected object files to avoid basename conflicts...
make[1]: Leaving directory '/home/ci/cibuild.20668/frr-source'
make[1]: Target 'all-am' not remade because of errors.
FreeBSD 12 amd64 build: Failed (click for details)

Make failed for FreeBSD 12 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-20668/artifact/FBSD12AMD64/ErrorLog/log_make.txt)

 static void elffile_add_dynreloc(struct elffile *w, Elf_Data *reldata,
bgpd/bgp_damp.c: In function 'bgp_reuse_timer':
bgpd/bgp_damp.c:191:2: error: 'node' undeclared (first use in this function); did you mean 'modf'?
bgpd/bgp_damp.c:191:2: note: each undeclared identifier is reported only once for each function it appears in
gmake[1]: *** [Makefile:9737: bgpd/bgp_damp.o] Error 1
copying selected object files to avoid basename conflicts...
gmake[1]: Target 'all-am' not remade because of errors.
gmake[1]: Leaving directory '/usr/home/ci/cibuild.20668/frr-source'
gmake: *** [Makefile:6016: all] Error 2

FreeBSD 12 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-20668/artifact/FBSD12AMD64/config.status/config.status
FreeBSD 12 amd64 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-20668/artifact/FBSD12AMD64/config.log/config.log.gz

Ubuntu 18.04 amd64 build: Failed (click for details)

Make failed for Ubuntu 18.04 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-20668/artifact/U1804AMD64/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.20668/frr-source'
bgpd/bgp_damp.c: In function bgp_reuse_timer:
bgpd/bgp_damp.c:191:2: error: node undeclared (first use in this function); did you mean modf?
bgpd/bgp_damp.c:191:2: note: each undeclared identifier is reported only once for each function it appears in
Makefile:9123: recipe for target 'bgpd/bgp_damp.o' failed
make[1]: *** [bgpd/bgp_damp.o] Error 1
copying selected object files to avoid basename conflicts...
make[1]: Leaving directory '/home/ci/cibuild.20668/frr-source'
make[1]: Target 'all-am' not remade because of errors.

Ubuntu 18.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-20668/artifact/U1804AMD64/config.status/config.status
Ubuntu 18.04 amd64 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-20668/artifact/U1804AMD64/config.log/config.log.gz

Ubuntu 16.04 arm7 build: Failed (click for details) Ubuntu 16.04 arm7 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-20668/artifact/CI101BUILD/config.status/config.status Ubuntu 16.04 arm7 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-20668/artifact/CI101BUILD/config.log/config.log.gz

Make failed for Ubuntu 16.04 arm7 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-20668/artifact/CI101BUILD/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.20668/frr-source'
bgpd/bgp_damp.c: In function bgp_reuse_timer:
bgpd/bgp_damp.c:191:2: error: node undeclared (first use in this function)
bgpd/bgp_damp.c:191:2: note: each undeclared identifier is reported only once for each function it appears in
Makefile:9123: recipe for target 'bgpd/bgp_damp.o' failed
make[1]: *** [bgpd/bgp_damp.o] Error 1
/home/ci/cibuild.20668/frr-source/doc/user/zebra.rst:23: SEVERE: Duplicate ID: "cmdoption-configure-arg-net".
/home/ci/cibuild.20668/frr-source/doc/user/zebra.rst:23: SEVERE: Duplicate ID: "cmdoption-configure-arg-net".
/home/ci/cibuild.20668/frr-source/doc/user/zebra.rst:23: SEVERE: Duplicate ID: "cmdoption-configure-arg-net".
CentOS 8 amd64 build: Failed (click for details) CentOS 8 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-20668/artifact/CENTOS8BUILD/config.status/config.status

Make failed for CentOS 8 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-20668/artifact/CENTOS8BUILD/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.20668/frr-source'
bgpd/bgp_damp.c: In function bgp_reuse_timer:
bgpd/bgp_damp.c:191:2: error: node undeclared (first use in this function); did you mean modf?
bgpd/bgp_damp.c:191:2: note: each undeclared identifier is reported only once for each function it appears in
make[1]: *** [Makefile:9737: bgpd/bgp_damp.o] Error 1
copying selected object files to avoid basename conflicts...
make[1]: Leaving directory '/home/ci/cibuild.20668/frr-source'
make[1]: Target 'all-am' not remade because of errors.
make: *** [Makefile:6016: all] Error 2

CentOS 8 amd64 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-20668/artifact/CENTOS8BUILD/config.log/config.log.gz

Debian 9 amd64 build: Failed (click for details)

Make failed for Debian 9 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-20668/artifact/CI021BUILD/ErrorLog/log_make.txt)

/home/ci/cibuild.20668/frr-source/doc/user/zebra.rst:23: SEVERE: Duplicate ID: "cmdoption-configure-arg-net".
bgpd/bgp_damp.c: In function bgp_reuse_timer:
bgpd/bgp_damp.c:191:2: error: node undeclared (first use in this function)
bgpd/bgp_damp.c:191:2: note: each undeclared identifier is reported only once for each function it appears in
Makefile:9123: recipe for target 'bgpd/bgp_damp.o' failed
make[1]: *** [bgpd/bgp_damp.o] Error 1
/home/ci/cibuild.20668/frr-source/doc/user/zebra.rst:23: SEVERE: Duplicate ID: "cmdoption-configure-arg-net".
/home/ci/cibuild.20668/frr-source/doc/user/zebra.rst:23: SEVERE: Duplicate ID: "cmdoption-configure-arg-net".
/home/ci/cibuild.20668/frr-source/doc/user/zebra.rst:23: SEVERE: Duplicate ID: "cmdoption-configure-arg-net".

Debian 9 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-20668/artifact/CI021BUILD/config.status/config.status
Debian 9 amd64 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-20668/artifact/CI021BUILD/config.log/config.log.gz

Ubuntu 18.04 ppc64le build: Failed (click for details)

Make failed for Ubuntu 18.04 ppc64le build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-20668/artifact/U1804PPC64LEBUILD/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.20668/frr-source'
bgpd/bgp_damp.c: In function bgp_reuse_timer:
bgpd/bgp_damp.c:191:2: error: node undeclared (first use in this function); did you mean modf?
bgpd/bgp_damp.c:191:2: note: each undeclared identifier is reported only once for each function it appears in
Makefile:9123: recipe for target 'bgpd/bgp_damp.o' failed
make[1]: *** [bgpd/bgp_damp.o] Error 1
copying selected object files to avoid basename conflicts...
make[1]: Leaving directory '/home/ci/cibuild.20668/frr-source'
Makefile:5408: recipe for target 'all' failed

Ubuntu 18.04 ppc64le build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-20668/artifact/U1804PPC64LEBUILD/config.status/config.status
Ubuntu 18.04 ppc64le build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-20668/artifact/U1804PPC64LEBUILD/config.log/config.log.gz

NetBSD 8 amd64 build: Failed (click for details) NetBSD 8 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-20668/artifact/CI012BUILD/config.log/config.log.gz

Make failed for NetBSD 8 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-20668/artifact/CI012BUILD/ErrorLog/log_make.txt)

 static void elffile_add_dynreloc(struct elffile *w, Elf_Data *reldata,
bgpd/bgp_damp.c: In function 'bgp_reuse_timer':
bgpd/bgp_damp.c:191:2: error: 'node' undeclared (first use in this function)
bgpd/bgp_damp.c:191:2: note: each undeclared identifier is reported only once for each function it appears in
gmake[1]: *** [Makefile:9737: bgpd/bgp_damp.o] Error 1
ld: warning: libintl.so.1, needed by /usr/pkg/lib/libpython3.7.so, may conflict with libintl.so.8
doc/user/_build/texinfo/frr.texi:5: warning: unrecognized encoding name `UTF-8'.
doc/user/_build/texinfo/frr.texi:14545: warning: @image file `frr-figures/fig-normal-processing.txt' (for text) unreadable: No such file or directory.
doc/user/_build/texinfo/frr.texi:14555: warning: @image file `frr-figures/fig_topologies_full.txt' (for text) unreadable: No such file or directory.

NetBSD 8 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-20668/artifact/CI012BUILD/config.status/config.status

Ubuntu 16.04 amd64 build: Failed (click for details)

Make failed for Ubuntu 16.04 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-20668/artifact/CI014BUILD/ErrorLog/log_make.txt)

/home/ci/cibuild.20668/frr-source/doc/user/zebra.rst:23: SEVERE: Duplicate ID: "cmdoption-configure-arg-net".
bgpd/bgp_damp.c: In function bgp_reuse_timer:
bgpd/bgp_damp.c:191:2: error: node undeclared (first use in this function)
bgpd/bgp_damp.c:191:2: note: each undeclared identifier is reported only once for each function it appears in
Makefile:9123: recipe for target 'bgpd/bgp_damp.o' failed
make[1]: *** [bgpd/bgp_damp.o] Error 1
/home/ci/cibuild.20668/frr-source/doc/user/zebra.rst:23: SEVERE: Duplicate ID: "cmdoption-configure-arg-net".
/home/ci/cibuild.20668/frr-source/doc/user/zebra.rst:23: SEVERE: Duplicate ID: "cmdoption-configure-arg-net".
/home/ci/cibuild.20668/frr-source/doc/user/zebra.rst:23: SEVERE: Duplicate ID: "cmdoption-configure-arg-net".

Ubuntu 16.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-20668/artifact/CI014BUILD/config.status/config.status
Ubuntu 16.04 amd64 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-20668/artifact/CI014BUILD/config.log/config.log.gz

Ubuntu 18.04 arm7 build: Failed (click for details)

Make failed for Ubuntu 18.04 arm7 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-20668/artifact/U18ARM7BUILD/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.20668/frr-source'
bgpd/bgp_damp.c: In function bgp_reuse_timer:
bgpd/bgp_damp.c:191:2: error: node undeclared (first use in this function); did you mean modf?
bgpd/bgp_damp.c:191:2: note: each undeclared identifier is reported only once for each function it appears in
Makefile:9123: recipe for target 'bgpd/bgp_damp.o' failed
make[1]: *** [bgpd/bgp_damp.o] Error 1
copying selected object files to avoid basename conflicts...
make[1]: Target 'all-am' not remade because of errors.
make[1]: Leaving directory '/home/ci/cibuild.20668/frr-source'

Ubuntu 18.04 arm7 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-20668/artifact/U18ARM7BUILD/config.log/config.log.gz
Ubuntu 18.04 arm7 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-20668/artifact/U18ARM7BUILD/config.status/config.status

Ubuntu 16.04 arm8 build: Failed (click for details)

Make failed for Ubuntu 16.04 arm8 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-20668/artifact/U16ARM8BUILD/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.20668/frr-source'
bgpd/bgp_damp.c: In function bgp_reuse_timer:
bgpd/bgp_damp.c:191:2: error: node undeclared (first use in this function)
bgpd/bgp_damp.c:191:2: note: each undeclared identifier is reported only once for each function it appears in
Makefile:9123: recipe for target 'bgpd/bgp_damp.o' failed
make[1]: *** [bgpd/bgp_damp.o] Error 1
/home/ci/cibuild.20668/frr-source/doc/user/zebra.rst:23: SEVERE: Duplicate ID: "cmdoption-configure-arg-net".
/home/ci/cibuild.20668/frr-source/doc/user/zebra.rst:23: SEVERE: Duplicate ID: "cmdoption-configure-arg-net".
/home/ci/cibuild.20668/frr-source/doc/user/zebra.rst:23: SEVERE: Duplicate ID: "cmdoption-configure-arg-net".

Ubuntu 16.04 arm8 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-20668/artifact/U16ARM8BUILD/config.log/config.log.gz
Ubuntu 16.04 arm8 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-20668/artifact/U16ARM8BUILD/config.status/config.status

Debian 11 amd64 build: Failed (click for details) Debian 11 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-20668/artifact/DEB11AMD64/config.status/config.status

Make failed for Debian 11 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-20668/artifact/DEB11AMD64/ErrorLog/log_make.txt)

/home/ci/cibuild.20668/frr-source/doc/user/zebra.rst:1183: WARNING: duplicate clicmd description of debug zebra pbr, other instance in pbr
bgpd/bgp_damp.c: In function bgp_reuse_timer:
bgpd/bgp_damp.c:191:2: error: node undeclared (first use in this function)
bgpd/bgp_damp.c:191:2: note: each undeclared identifier is reported only once for each function it appears in
make[1]: *** [Makefile:9741: bgpd/bgp_damp.o] Error 1
copying selected object files to avoid basename conflicts...
make[1]: Leaving directory '/home/ci/cibuild.20668/frr-source'
make[1]: Target 'all-am' not remade because of errors.
make: *** [Makefile:6020: all] Error 2

Debian 11 amd64 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-20668/artifact/DEB11AMD64/config.log/config.log.gz

Ubuntu 20.04 amd64 build: Failed (click for details) Ubuntu 20.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-20668/artifact/U2004AMD64BUILD/config.status/config.status

Make failed for Ubuntu 20.04 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-20668/artifact/U2004AMD64BUILD/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.20668/frr-source'
bgpd/bgp_damp.c: In function bgp_reuse_timer:
bgpd/bgp_damp.c:191:2: error: node undeclared (first use in this function)
bgpd/bgp_damp.c:191:2: note: each undeclared identifier is reported only once for each function it appears in
make[1]: *** [Makefile:9738: bgpd/bgp_damp.o] Error 1
copying selected object files to avoid basename conflicts...
make[1]: Target 'all-am' not remade because of errors.
make[1]: Leaving directory '/home/ci/cibuild.20668/frr-source'
make: *** [Makefile:6017: all] Error 2

Ubuntu 20.04 amd64 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-20668/artifact/U2004AMD64BUILD/config.log/config.log.gz

Ubuntu 16.04 i386 build: Failed (click for details)

Make failed for Ubuntu 16.04 i386 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-20668/artifact/U1604I386/ErrorLog/log_make.txt)

/home/ci/cibuild.20668/frr-source/doc/user/zebra.rst:23: SEVERE: Duplicate ID: "cmdoption-configure-arg-net".
bgpd/bgp_damp.c: In function bgp_reuse_timer:
bgpd/bgp_damp.c:191:2: error: node undeclared (first use in this function)
bgpd/bgp_damp.c:191:2: note: each undeclared identifier is reported only once for each function it appears in
Makefile:9123: recipe for target 'bgpd/bgp_damp.o' failed
make[1]: *** [bgpd/bgp_damp.o] Error 1
/home/ci/cibuild.20668/frr-source/doc/user/zebra.rst:23: SEVERE: Duplicate ID: "cmdoption-configure-arg-net".
/home/ci/cibuild.20668/frr-source/doc/user/zebra.rst:23: SEVERE: Duplicate ID: "cmdoption-configure-arg-net".
/home/ci/cibuild.20668/frr-source/doc/user/zebra.rst:23: SEVERE: Duplicate ID: "cmdoption-configure-arg-net".

Ubuntu 16.04 i386 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-20668/artifact/U1604I386/config.status/config.status
Ubuntu 16.04 i386 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-20668/artifact/U1604I386/config.log/config.log.gz

@NetDEF-CI
Copy link
Collaborator

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-20669/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

@idryzhov
Copy link
Contributor

idryzhov commented Aug 2, 2021

Note for the reviewers – let's decide on the #9256 first. These commits don't fully fix crashes and memory leaks in dampening code.

riw777
riw777 approved these changes Aug 3, 2021
View reviewed changes
Copy link
Member

@riw777 riw777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good ... thanks

@riw777 riw777 merged commit 9f46450 into FRRouting:stable/8.0 Aug 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@riw777 riw777 riw777 approved these changes

Assignees
No one assigned
Labels
bgp bugfix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@ton31337 @LabN-CI @NetDEF-CI @idryzhov @riw777 @polychaeta